You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2021/04/08 17:49:31 UTC
[Impala-ASF-CR] Revert "IMPALA-10613: Standup HMS thrift server in Catalog"
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17290
Change subject: Revert "IMPALA-10613: Standup HMS thrift server in Catalog"
......................................................................
Revert "IMPALA-10613: Standup HMS thrift server in Catalog"
There are issues building this patch against other
Hive versions, so reverting until those can be addressed.
This reverts commit a7eae471b84f05816780093938bba50f4d78aef1.
Change-Id: Id952ee063095a9c36c4619b7238b71cfcb7d61f3
---
M be/src/catalog/catalog-server.cc
M be/src/common/global-flags.cc
M be/src/util/backend-gflag-util.cc
M common/thrift/BackendGflags.thrift
M common/thrift/CatalogService.thrift
M fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java
D fe/src/main/java/org/apache/impala/catalog/CatalogHmsAPIHelper.java
M fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java
D fe/src/main/java/org/apache/impala/catalog/GetPartialCatalogObjectRequestBuilder.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/ParallelFileMetadataLoader.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
D fe/src/main/java/org/apache/impala/catalog/metastore/CatalogHmsClientUtils.java
D fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServer.java
D fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java
D fe/src/main/java/org/apache/impala/catalog/metastore/ICatalogMetastoreServer.java
D fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java
D fe/src/main/java/org/apache/impala/catalog/metastore/NoOpCatalogMetastoreServer.java
M fe/src/main/java/org/apache/impala/service/BackendConfig.java
D fe/src/test/java/org/apache/impala/catalog/metastore/CatalogHmsFileMetadataTest.java
D fe/src/test/java/org/apache/impala/catalog/metastore/EnableCatalogdHmsCacheFlagTest.java
M fe/src/test/java/org/apache/impala/testutil/CatalogServiceTestCatalog.java
M tests/common/impala_test_suite.py
D tests/custom_cluster/test_metastore_service.py
24 files changed, 22 insertions(+), 5,398 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/90/17290/1
--
To view, visit http://gerrit.cloudera.org:8080/17290
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id952ee063095a9c36c4619b7238b71cfcb7d61f3
Gerrit-Change-Number: 17290
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
[Impala-ASF-CR] Revert "IMPALA-10613: Standup HMS thrift server in Catalog"
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17290 )
Change subject: Revert "IMPALA-10613: Standup HMS thrift server in Catalog"
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7056/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/17290
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id952ee063095a9c36c4619b7238b71cfcb7d61f3
Gerrit-Change-Number: 17290
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 Apr 2021 18:07:16 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Revert "IMPALA-10613: Standup HMS thrift server in Catalog"
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17290 )
Change subject: Revert "IMPALA-10613: Standup HMS thrift server in Catalog"
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/17290
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id952ee063095a9c36c4619b7238b71cfcb7d61f3
Gerrit-Change-Number: 17290
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 Apr 2021 23:51:04 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Revert "IMPALA-10613: Standup HMS thrift server in Catalog"
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17290 )
Change subject: Revert "IMPALA-10613: Standup HMS thrift server in Catalog"
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/8525/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17290
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id952ee063095a9c36c4619b7238b71cfcb7d61f3
Gerrit-Change-Number: 17290
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 Apr 2021 18:09:42 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Revert "IMPALA-10613: Standup HMS thrift server in Catalog"
Posted by "Vihang Karajgaonkar (Code Review)" <ge...@cloudera.org>.
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17290 )
Change subject: Revert "IMPALA-10613: Standup HMS thrift server in Catalog"
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17290
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id952ee063095a9c36c4619b7238b71cfcb7d61f3
Gerrit-Change-Number: 17290
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 Apr 2021 21:14:39 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Revert "IMPALA-10613: Standup HMS thrift server in Catalog"
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17290 )
Change subject: Revert "IMPALA-10613: Standup HMS thrift server in Catalog"
......................................................................
Revert "IMPALA-10613: Standup HMS thrift server in Catalog"
There are issues building this patch against other
Hive versions, so reverting until those can be addressed.
This reverts commit a7eae471b84f05816780093938bba50f4d78aef1.
Change-Id: Id952ee063095a9c36c4619b7238b71cfcb7d61f3
Reviewed-on: http://gerrit.cloudera.org:8080/17290
Reviewed-by: Vihang Karajgaonkar <vi...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/catalog/catalog-server.cc
M be/src/common/global-flags.cc
M be/src/util/backend-gflag-util.cc
M common/thrift/BackendGflags.thrift
M common/thrift/CatalogService.thrift
M fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java
D fe/src/main/java/org/apache/impala/catalog/CatalogHmsAPIHelper.java
M fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java
D fe/src/main/java/org/apache/impala/catalog/GetPartialCatalogObjectRequestBuilder.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/ParallelFileMetadataLoader.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
D fe/src/main/java/org/apache/impala/catalog/metastore/CatalogHmsClientUtils.java
D fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServer.java
D fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java
D fe/src/main/java/org/apache/impala/catalog/metastore/ICatalogMetastoreServer.java
D fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java
D fe/src/main/java/org/apache/impala/catalog/metastore/NoOpCatalogMetastoreServer.java
M fe/src/main/java/org/apache/impala/service/BackendConfig.java
D fe/src/test/java/org/apache/impala/catalog/metastore/CatalogHmsFileMetadataTest.java
D fe/src/test/java/org/apache/impala/catalog/metastore/EnableCatalogdHmsCacheFlagTest.java
M fe/src/test/java/org/apache/impala/testutil/CatalogServiceTestCatalog.java
M tests/common/impala_test_suite.py
D tests/custom_cluster/test_metastore_service.py
24 files changed, 22 insertions(+), 5,398 deletions(-)
Approvals:
Vihang Karajgaonkar: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/17290
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id952ee063095a9c36c4619b7238b71cfcb7d61f3
Gerrit-Change-Number: 17290
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>