You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Lars Volker (Code Review)" <ge...@cloudera.org> on 2017/06/02 18:08:23 UTC

[Impala-ASF-CR] IMPALA-5424: Ignore errors when removing minidumps folder

Lars Volker has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/7062

Change subject: IMPALA-5424: Ignore errors when removing minidumps folder
......................................................................

IMPALA-5424: Ignore errors when removing minidumps folder

On developer machines it can happen that /tmp/minidumps does not exists
when test_minidump_relative_path gets executed. In this case errors from
rmtree should be ignored.

Change-Id: Ifab76a30898805d2df5e7452079a536d8747ac50
---
M tests/custom_cluster/test_breakpad.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/62/7062/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7062
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifab76a30898805d2df5e7452079a536d8747ac50
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>

[Impala-ASF-CR] IMPALA-5424: Ignore errors when removing minidumps folder

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.

Change subject: IMPALA-5424: Ignore errors when removing minidumps folder
......................................................................


Patch Set 1:

Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/672/

-- 
To view, visit http://gerrit.cloudera.org:8080/7062
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifab76a30898805d2df5e7452079a536d8747ac50
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5424: Ignore errors when removing minidumps folder

Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change.

Change subject: IMPALA-5424: Ignore errors when removing minidumps folder
......................................................................


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/7062
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifab76a30898805d2df5e7452079a536d8747ac50
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5424: Ignore errors when removing minidumps folder

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.

Change subject: IMPALA-5424: Ignore errors when removing minidumps folder
......................................................................


Patch Set 1: Verified+1

-- 
To view, visit http://gerrit.cloudera.org:8080/7062
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifab76a30898805d2df5e7452079a536d8747ac50
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5424: Ignore errors when removing minidumps folder

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.

Change subject: IMPALA-5424: Ignore errors when removing minidumps folder
......................................................................


IMPALA-5424: Ignore errors when removing minidumps folder

On developer machines it can happen that /tmp/minidumps does not exists
when test_minidump_relative_path gets executed. In this case errors from
rmtree should be ignored.

Change-Id: Ifab76a30898805d2df5e7452079a536d8747ac50
Reviewed-on: http://gerrit.cloudera.org:8080/7062
Reviewed-by: Alex Behm <al...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M tests/custom_cluster/test_breakpad.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Impala Public Jenkins: Verified
  Alex Behm: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/7062
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifab76a30898805d2df5e7452079a536d8747ac50
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins