You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Navis Ryu <na...@nexr.com> on 2011/08/08 09:26:17 UTC
Review Request: HIVE-2332 If all of the parameters of distinct functions are
exists in group by columns, query fails in runtime
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1314/
-----------------------------------------------------------
Review request for hive.
Summary
-------
If all of the distinct params are in group by keys, union column reserved for distinct params would not be added, which making problems initializing RS operator.
This patch is just a simple bypass adding dummy expression for the union column. Someone would know better way to resolve the problem.
This addresses bug HIVE-2332.
https://issues.apache.org/jira/browse/HIVE-2332
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java dc9ab1b
ql/src/test/queries/clientpositive/groupby_distinct_samekey.q PRE-CREATION
ql/src/test/results/clientpositive/groupby_distinct_samekey.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/1314/diff
Testing
-------
Thanks,
Navis
Re: Review Request: HIVE-2332 If all of the parameters of distinct functions
are exists in group by columns, query fails in runtime
Posted by Navis Ryu <na...@nexr.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1314/
-----------------------------------------------------------
(Updated 2011-12-07 07:01:30.547976)
Review request for hive, John Sichi and Carl Steinbach.
Changes
-------
Adding null keys induced confusions especially for optimizers. This patch just modifies key-order minimizing side effects.
Summary
-------
If all of the distinct params are in group by keys, union column reserved for distinct params would not be added, which making problems initializing RS operator.
This patch is just a simple bypass adding dummy expression for the union column. Someone would know better way to resolve the problem.
This addresses bug HIVE-2332.
https://issues.apache.org/jira/browse/HIVE-2332
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/exec/ReduceSinkOperator.java 732a5aa
ql/src/java/org/apache/hadoop/hive/ql/plan/PlanUtils.java c6ae55d
ql/src/test/queries/clientpositive/groupby_distinct_samekey.q PRE-CREATION
ql/src/test/results/clientpositive/groupby_distinct_samekey.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/1314/diff
Testing
-------
added clientpositive/groupby_distinct_samekey.q
Thanks,
Navis
Re: Review Request: HIVE-2332 If all of the parameters of distinct functions
are exists in group by columns, query fails in runtime
Posted by Navis Ryu <na...@nexr.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1314/
-----------------------------------------------------------
(Updated 2011-11-15 08:56:07.599798)
Review request for hive and Ashutosh Chauhan.
Changes
-------
Rebased to trunk.
Summary
-------
If all of the distinct params are in group by keys, union column reserved for distinct params would not be added, which making problems initializing RS operator.
This patch is just a simple bypass adding dummy expression for the union column. Someone would know better way to resolve the problem.
This addresses bug HIVE-2332.
https://issues.apache.org/jira/browse/HIVE-2332
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java d60ba09
ql/src/test/queries/clientpositive/groupby_distinct_samekey.q PRE-CREATION
ql/src/test/results/clientpositive/groupby_distinct_samekey.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/1314/diff
Testing (updated)
-------
added clientpositive/groupby_distinct_samekey.q
Thanks,
Navis