You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by saksham srivastava <sa...@citrix.com> on 2013/01/09 08:29:50 UTC
Review Request: CLOUDSTACK-924: source_template_id set to NULL when a
template is created from a snapshot
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8900/
-----------------------------------------------------------
Review request for cloudstack and Devdeep Singh.
Description
-------
Volumes created from snapshots misses the source template information.Fixed the issue with volumes now getting the template id.
This addresses bug CLOUDSTACK-924.
Diffs
-----
server/src/com/cloud/storage/StorageManagerImpl.java 96f299c
Diff: https://reviews.apache.org/r/8900/diff/
Testing
-------
Verified on local setup. from template1->instance->snapshot1->volume1->snapshot2->template2
template2 now has source template id.
Thanks,
saksham srivastava
Re: Review Request: CLOUDSTACK-924: source_template_id set to NULL
when a template is created from a snapshot
Posted by Nitin Mehta <Ni...@citrix.com>.
Pushed with commit 75261eb317a763114a6054664f4adf3f7a2c2709
Please build and run it at your end
From: Saksham Srivastava <sa...@citrix.com>>
Reply-To: Saksham Srivastava <sa...@citrix.com>>
To: Nitin Mehta <ni...@citrix.com>>, Devdeep Singh <de...@citrix.com>>
Cc: Saksham Srivastava <sa...@citrix.com>>, "cloudstack-dev@incubator.apache.org<ma...@incubator.apache.org>" <cl...@incubator.apache.org>>
Subject: Re: Review Request: CLOUDSTACK-924: source_template_id set to NULL when a template is created from a snapshot
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8900/
Review request for cloudstack, Devdeep Singh and Nitin Mehta.
By Saksham Srivastava.
Updated March 11, 2013, 10:43 a.m.
Changes
New patch after resolving merge conflicts.
Description
Volumes created from snapshots misses the source template information.Fixed the issue with volumes now getting the template id.
Testing
Verified on local setup. from template1->instance->snapshot1->volume1->snapshot2->template2
template2 now has source template id.
Bugs: CLOUDSTACK-924
Diffs (updated)
* server/src/com/cloud/storage/VolumeManagerImpl.java (f0e6028)
View Diff<https://reviews.apache.org/r/8900/diff/>
Re: Review Request: CLOUDSTACK-924: source_template_id set to NULL when a
template is created from a snapshot
Posted by Saksham Srivastava <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8900/
-----------------------------------------------------------
(Updated March 11, 2013, 10:43 a.m.)
Review request for cloudstack, Devdeep Singh and Nitin Mehta.
Changes
-------
New patch after resolving merge conflicts.
Description
-------
Volumes created from snapshots misses the source template information.Fixed the issue with volumes now getting the template id.
This addresses bug CLOUDSTACK-924.
Diffs (updated)
-----
server/src/com/cloud/storage/VolumeManagerImpl.java f0e6028
Diff: https://reviews.apache.org/r/8900/diff/
Testing
-------
Verified on local setup. from template1->instance->snapshot1->volume1->snapshot2->template2
template2 now has source template id.
Thanks,
Saksham Srivastava
RE: Review Request: CLOUDSTACK-924: source_template_id set to NULL
when a template is created from a snapshot
Posted by Animesh Chaturvedi <an...@citrix.com>.
Ok thanks for following up
Animesh
> -----Original Message-----
> From: Nitin Mehta
> Sent: Tuesday, March 05, 2013 12:00 AM
> To: Animesh Chaturvedi; cloudstack-dev@incubator.apache.org; Saksham
> Srivastava; Devdeep Singh; Abhinandan Prateek
> Subject: Re: Review Request: CLOUDSTACK-924: source_template_id set to
> NULL when a template is created from a snapshot
>
> Hi Animesh,
> Saksham is supposed to send a rebased request to me. Below is what he
> wrote to me.
>
>
>
> The code has changed a lot after the storage refactoring.
> I will submit a new patch after resolving the conflicts.
>
> Saksham
>
>
> On Thursday 28 February 2013 12:03 PM, Nitin Mehta wrote:
> >Nitins-MacBook-Air:incubator-cloudstack nitinmehta$ git apply
> >--whitespace=fix ../pppp.patch
> >error: patch failed:
> >server/src/com/cloud/storage/StorageManagerImpl.java:477
> >error: server/src/com/cloud/storage/StorageManagerImpl.java: patch does
> >not apply Nitins-MacBook-Air:incubator-cloudstack nitinmehta$
> >
>
>
>
> On 01/03/13 3:57 AM, "Animesh Chaturvedi"
> <an...@citrix.com>
> wrote:
>
> >Nitin
> >
> >This has been pending your review since couple of days. Please attend
> >to this review and close it
> >
> >Animesh
> >
> >> -----Original Message-----
> >> From: Animesh Chaturvedi [mailto:animesh.chaturvedi@citrix.com]
> >> Sent: Wednesday, February 13, 2013 7:34 PM
> >> To: Saksham Srivastava; Nitin Mehta; Devdeep Singh
> >> Cc: cloudstack
> >> Subject: RE: Review Request: CLOUDSTACK-924: source_template_id set
> >> to NULL when a template is created from a snapshot
> >>
> >> Nitin
> >>
> >> Please review the updates patch and commit if satisfied
> >>
> >> > -----Original Message-----
> >> > From: Saksham Srivastava [mailto:noreply@reviews.apache.org] On
> >> > Behalf Of Saksham Srivastava
> >> > Sent: Monday, February 11, 2013 3:38 AM
> >> > To: Nitin Mehta; Devdeep Singh
> >> > Cc: Saksham Srivastava; cloudstack
> >> > Subject: Re: Review Request: CLOUDSTACK-924: source_template_id
> set
> >> > to NULL when a template is created from a snapshot
> >> >
> >> >
> >> > -----------------------------------------------------------
> >> > This is an automatically generated e-mail. To reply, visit:
> >> > https://reviews.apache.org/r/8900/
> >> > -----------------------------------------------------------
> >> >
> >> > (Updated Feb. 11, 2013, 11:37 a.m.)
> >> >
> >> >
> >> > Review request for cloudstack, Devdeep Singh and Nitin Mehta.
> >> >
> >> >
> >> > Description
> >> > -------
> >> >
> >> > Volumes created from snapshots misses the source template
> >> > information.Fixed the issue with volumes now getting the template id.
> >> >
> >> >
> >> > This addresses bug CLOUDSTACK-924.
> >> >
> >> >
> >> > Diffs
> >> > -----
> >> >
> >> > server/src/com/cloud/storage/StorageManagerImpl.java 05e0cfe
> >> >
> >> > Diff: https://reviews.apache.org/r/8900/diff/
> >> >
> >> >
> >> > Testing
> >> > -------
> >> >
> >> > Verified on local setup. from
> >> > template1->instance->snapshot1->volume1-
> >> > >snapshot2->template2
> >> > template2 now has source template id.
> >> >
> >> >
> >> > Thanks,
> >> >
> >> > Saksham Srivastava
> >
Re: Review Request: CLOUDSTACK-924: source_template_id set to NULL
when a template is created from a snapshot
Posted by Nitin Mehta <Ni...@citrix.com>.
Hi Animesh,
Saksham is supposed to send a rebased request to me. Below is what he
wrote to me.
The code has changed a lot after the storage refactoring.
I will submit a new patch after resolving the conflicts.
Saksham
On Thursday 28 February 2013 12:03 PM, Nitin Mehta wrote:
>Nitins-MacBook-Air:incubator-cloudstack nitinmehta$ git apply
>--whitespace=fix ../pppp.patch
>error: patch failed:
>server/src/com/cloud/storage/StorageManagerImpl.java:477
>error: server/src/com/cloud/storage/StorageManagerImpl.java: patch does
>not apply
>Nitins-MacBook-Air:incubator-cloudstack nitinmehta$
>
On 01/03/13 3:57 AM, "Animesh Chaturvedi" <an...@citrix.com>
wrote:
>Nitin
>
>This has been pending your review since couple of days. Please attend to
>this review and close it
>
>Animesh
>
>> -----Original Message-----
>> From: Animesh Chaturvedi [mailto:animesh.chaturvedi@citrix.com]
>> Sent: Wednesday, February 13, 2013 7:34 PM
>> To: Saksham Srivastava; Nitin Mehta; Devdeep Singh
>> Cc: cloudstack
>> Subject: RE: Review Request: CLOUDSTACK-924: source_template_id set to
>> NULL when a template is created from a snapshot
>>
>> Nitin
>>
>> Please review the updates patch and commit if satisfied
>>
>> > -----Original Message-----
>> > From: Saksham Srivastava [mailto:noreply@reviews.apache.org] On Behalf
>> > Of Saksham Srivastava
>> > Sent: Monday, February 11, 2013 3:38 AM
>> > To: Nitin Mehta; Devdeep Singh
>> > Cc: Saksham Srivastava; cloudstack
>> > Subject: Re: Review Request: CLOUDSTACK-924: source_template_id set to
>> > NULL when a template is created from a snapshot
>> >
>> >
>> > -----------------------------------------------------------
>> > This is an automatically generated e-mail. To reply, visit:
>> > https://reviews.apache.org/r/8900/
>> > -----------------------------------------------------------
>> >
>> > (Updated Feb. 11, 2013, 11:37 a.m.)
>> >
>> >
>> > Review request for cloudstack, Devdeep Singh and Nitin Mehta.
>> >
>> >
>> > Description
>> > -------
>> >
>> > Volumes created from snapshots misses the source template
>> > information.Fixed the issue with volumes now getting the template id.
>> >
>> >
>> > This addresses bug CLOUDSTACK-924.
>> >
>> >
>> > Diffs
>> > -----
>> >
>> > server/src/com/cloud/storage/StorageManagerImpl.java 05e0cfe
>> >
>> > Diff: https://reviews.apache.org/r/8900/diff/
>> >
>> >
>> > Testing
>> > -------
>> >
>> > Verified on local setup. from template1->instance->snapshot1->volume1-
>> > >snapshot2->template2
>> > template2 now has source template id.
>> >
>> >
>> > Thanks,
>> >
>> > Saksham Srivastava
>
RE: Review Request: CLOUDSTACK-924: source_template_id set to NULL
when a template is created from a snapshot
Posted by Animesh Chaturvedi <an...@citrix.com>.
Nitin
This has been pending your review since couple of days. Please attend to this review and close it
Animesh
> -----Original Message-----
> From: Animesh Chaturvedi [mailto:animesh.chaturvedi@citrix.com]
> Sent: Wednesday, February 13, 2013 7:34 PM
> To: Saksham Srivastava; Nitin Mehta; Devdeep Singh
> Cc: cloudstack
> Subject: RE: Review Request: CLOUDSTACK-924: source_template_id set to
> NULL when a template is created from a snapshot
>
> Nitin
>
> Please review the updates patch and commit if satisfied
>
> > -----Original Message-----
> > From: Saksham Srivastava [mailto:noreply@reviews.apache.org] On Behalf
> > Of Saksham Srivastava
> > Sent: Monday, February 11, 2013 3:38 AM
> > To: Nitin Mehta; Devdeep Singh
> > Cc: Saksham Srivastava; cloudstack
> > Subject: Re: Review Request: CLOUDSTACK-924: source_template_id set to
> > NULL when a template is created from a snapshot
> >
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/8900/
> > -----------------------------------------------------------
> >
> > (Updated Feb. 11, 2013, 11:37 a.m.)
> >
> >
> > Review request for cloudstack, Devdeep Singh and Nitin Mehta.
> >
> >
> > Description
> > -------
> >
> > Volumes created from snapshots misses the source template
> > information.Fixed the issue with volumes now getting the template id.
> >
> >
> > This addresses bug CLOUDSTACK-924.
> >
> >
> > Diffs
> > -----
> >
> > server/src/com/cloud/storage/StorageManagerImpl.java 05e0cfe
> >
> > Diff: https://reviews.apache.org/r/8900/diff/
> >
> >
> > Testing
> > -------
> >
> > Verified on local setup. from template1->instance->snapshot1->volume1-
> > >snapshot2->template2
> > template2 now has source template id.
> >
> >
> > Thanks,
> >
> > Saksham Srivastava
RE: Review Request: CLOUDSTACK-924: source_template_id set to NULL
when a template is created from a snapshot
Posted by Animesh Chaturvedi <an...@citrix.com>.
Nitin
Please review the updates patch and commit if satisfied
> -----Original Message-----
> From: Saksham Srivastava [mailto:noreply@reviews.apache.org] On Behalf Of
> Saksham Srivastava
> Sent: Monday, February 11, 2013 3:38 AM
> To: Nitin Mehta; Devdeep Singh
> Cc: Saksham Srivastava; cloudstack
> Subject: Re: Review Request: CLOUDSTACK-924: source_template_id set to
> NULL when a template is created from a snapshot
>
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8900/
> -----------------------------------------------------------
>
> (Updated Feb. 11, 2013, 11:37 a.m.)
>
>
> Review request for cloudstack, Devdeep Singh and Nitin Mehta.
>
>
> Description
> -------
>
> Volumes created from snapshots misses the source template information.Fixed
> the issue with volumes now getting the template id.
>
>
> This addresses bug CLOUDSTACK-924.
>
>
> Diffs
> -----
>
> server/src/com/cloud/storage/StorageManagerImpl.java 05e0cfe
>
> Diff: https://reviews.apache.org/r/8900/diff/
>
>
> Testing
> -------
>
> Verified on local setup. from template1->instance->snapshot1->volume1-
> >snapshot2->template2
> template2 now has source template id.
>
>
> Thanks,
>
> Saksham Srivastava
Re: Review Request: CLOUDSTACK-924: source_template_id set to NULL when a
template is created from a snapshot
Posted by Saksham Srivastava <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8900/
-----------------------------------------------------------
(Updated Feb. 11, 2013, 11:37 a.m.)
Review request for cloudstack, Devdeep Singh and Nitin Mehta.
Description
-------
Volumes created from snapshots misses the source template information.Fixed the issue with volumes now getting the template id.
This addresses bug CLOUDSTACK-924.
Diffs
-----
server/src/com/cloud/storage/StorageManagerImpl.java 05e0cfe
Diff: https://reviews.apache.org/r/8900/diff/
Testing
-------
Verified on local setup. from template1->instance->snapshot1->volume1->snapshot2->template2
template2 now has source template id.
Thanks,
Saksham Srivastava
Re: Review Request: CLOUDSTACK-924: source_template_id set to NULL when a
template is created from a snapshot
Posted by Saksham Srivastava <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8900/
-----------------------------------------------------------
(Updated Feb. 11, 2013, 11:35 a.m.)
Review request for cloudstack and Devdeep Singh.
Changes
-------
Patch after latest rebase.
Description
-------
Volumes created from snapshots misses the source template information.Fixed the issue with volumes now getting the template id.
This addresses bug CLOUDSTACK-924.
Diffs (updated)
-----
server/src/com/cloud/storage/StorageManagerImpl.java 05e0cfe
Diff: https://reviews.apache.org/r/8900/diff/
Testing
-------
Verified on local setup. from template1->instance->snapshot1->volume1->snapshot2->template2
template2 now has source template id.
Thanks,
Saksham Srivastava
Re: Review Request: CLOUDSTACK-924: source_template_id set to NULL when a
template is created from a snapshot
Posted by Nitin Mehta <ni...@citrix.com>.
> On Jan. 9, 2013, 8:43 a.m., Nitin Mehta wrote:
> > You need to take care of migration as well. Any thoughts on that ?
>
> Saksham Srivastava wrote:
> The fix is only for the new volumes which are created from snapshots which were themselves created from volumes which have a non-null template id.
> In case of parent volume carrying a null template id, the subsequent volumes created from it will be having null template id.
>
>
>
Ok. Agreed that its not an easy problem to solve.
Sorry for the delay but can you rebase your changes and send it back ?
- Nitin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8900/#review15181
-----------------------------------------------------------
On Jan. 9, 2013, 7:29 a.m., Saksham Srivastava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8900/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2013, 7:29 a.m.)
>
>
> Review request for cloudstack and Devdeep Singh.
>
>
> Description
> -------
>
> Volumes created from snapshots misses the source template information.Fixed the issue with volumes now getting the template id.
>
>
> This addresses bug CLOUDSTACK-924.
>
>
> Diffs
> -----
>
> server/src/com/cloud/storage/StorageManagerImpl.java 96f299c
>
> Diff: https://reviews.apache.org/r/8900/diff/
>
>
> Testing
> -------
>
> Verified on local setup. from template1->instance->snapshot1->volume1->snapshot2->template2
> template2 now has source template id.
>
>
> Thanks,
>
> Saksham Srivastava
>
>
RE: Review Request: CLOUDSTACK-924: source_template_id set to NULL
when a template is created from a snapshot
Posted by Saksham Srivastava <sa...@citrix.com>.
The whole issue was there because if a user wants to track the original template from which the final template was created there was no way, but after the fix whatever NEW templates are used to create a instance volume->snapshot->volume->snapshot->template, the final template will always have the original id.
I don't see a way to know the source template ids for existing volumes/templates. There may be deleted template/volumes and knowing the source template id may not be even useful in those cases. Also as you rightly mentioned volumes created from ISO will also have template_id as null.
I am not sure if this can be actually done, if you have any suggestion kindly share.
From: Nitin Mehta
Sent: Wednesday, January 09, 2013 5:21 PM
To: Saksham Srivastava; Devdeep Singh
Cc: cloudstack
Subject: Re: Review Request: CLOUDSTACK-924: source_template_id set to NULL when a template is created from a snapshot
Exactly, so this is not a full fledged fix. Do you have a plan in mind to take care of volumes already facing this issue ? Remember that the volumes created from ISO will also have template_id as null so I understand that this is a bit tricky.
From: Saksham Srivastava <sa...@citrix.com>>
Reply-To: Saksham Srivastava <sa...@citrix.com>>
To: Devdeep Singh <de...@citrix.com>>
Cc: Saksham Srivastava <sa...@citrix.com>>, "cloudstack-dev@incubator.apache.org<ma...@incubator.apache.org>" <cl...@incubator.apache.org>>, Nitin Mehta <ni...@citrix.com>>
Subject: Re: Review Request: CLOUDSTACK-924: source_template_id set to NULL when a template is created from a snapshot
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8900/
On January 9th, 2013, 8:43 a.m., Nitin Mehta wrote:
You need to take care of migration as well. Any thoughts on that ?
The fix is only for the new volumes which are created from snapshots which were themselves created from volumes which have a non-null template id.
In case of parent volume carrying a null template id, the subsequent volumes created from it will be having null template id.
- saksham
On January 9th, 2013, 7:29 a.m., saksham srivastava wrote:
Review request for cloudstack and Devdeep Singh.
By saksham srivastava.
Updated Jan. 9, 2013, 7:29 a.m.
Description
Volumes created from snapshots misses the source template information.Fixed the issue with volumes now getting the template id.
Testing
Verified on local setup. from template1->instance->snapshot1->volume1->snapshot2->template2
template2 now has source template id.
Bugs: CLOUDSTACK-924
Diffs
* server/src/com/cloud/storage/StorageManagerImpl.java (96f299c)
View Diff<https://reviews.apache.org/r/8900/diff/>
Re: Review Request: CLOUDSTACK-924: source_template_id set to NULL
when a template is created from a snapshot
Posted by Nitin Mehta <Ni...@citrix.com>.
Exactly, so this is not a full fledged fix. Do you have a plan in mind to take care of volumes already facing this issue ? Remember that the volumes created from ISO will also have template_id as null so I understand that this is a bit tricky.
From: Saksham Srivastava <sa...@citrix.com>>
Reply-To: Saksham Srivastava <sa...@citrix.com>>
To: Devdeep Singh <de...@citrix.com>>
Cc: Saksham Srivastava <sa...@citrix.com>>, "cloudstack-dev@incubator.apache.org<ma...@incubator.apache.org>" <cl...@incubator.apache.org>>, Nitin Mehta <ni...@citrix.com>>
Subject: Re: Review Request: CLOUDSTACK-924: source_template_id set to NULL when a template is created from a snapshot
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8900/
On January 9th, 2013, 8:43 a.m., Nitin Mehta wrote:
You need to take care of migration as well. Any thoughts on that ?
The fix is only for the new volumes which are created from snapshots which were themselves created from volumes which have a non-null template id.
In case of parent volume carrying a null template id, the subsequent volumes created from it will be having null template id.
- saksham
On January 9th, 2013, 7:29 a.m., saksham srivastava wrote:
Review request for cloudstack and Devdeep Singh.
By saksham srivastava.
Updated Jan. 9, 2013, 7:29 a.m.
Description
Volumes created from snapshots misses the source template information.Fixed the issue with volumes now getting the template id.
Testing
Verified on local setup. from template1->instance->snapshot1->volume1->snapshot2->template2
template2 now has source template id.
Bugs: CLOUDSTACK-924
Diffs
* server/src/com/cloud/storage/StorageManagerImpl.java (96f299c)
View Diff<https://reviews.apache.org/r/8900/diff/>
Re: Review Request: CLOUDSTACK-924: source_template_id set to NULL when a
template is created from a snapshot
Posted by saksham srivastava <sa...@citrix.com>.
> On Jan. 9, 2013, 8:43 a.m., Nitin Mehta wrote:
> > You need to take care of migration as well. Any thoughts on that ?
The fix is only for the new volumes which are created from snapshots which were themselves created from volumes which have a non-null template id.
In case of parent volume carrying a null template id, the subsequent volumes created from it will be having null template id.
- saksham
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8900/#review15181
-----------------------------------------------------------
On Jan. 9, 2013, 7:29 a.m., saksham srivastava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8900/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2013, 7:29 a.m.)
>
>
> Review request for cloudstack and Devdeep Singh.
>
>
> Description
> -------
>
> Volumes created from snapshots misses the source template information.Fixed the issue with volumes now getting the template id.
>
>
> This addresses bug CLOUDSTACK-924.
>
>
> Diffs
> -----
>
> server/src/com/cloud/storage/StorageManagerImpl.java 96f299c
>
> Diff: https://reviews.apache.org/r/8900/diff/
>
>
> Testing
> -------
>
> Verified on local setup. from template1->instance->snapshot1->volume1->snapshot2->template2
> template2 now has source template id.
>
>
> Thanks,
>
> saksham srivastava
>
>
Re: Review Request: CLOUDSTACK-924: source_template_id set to NULL when a
template is created from a snapshot
Posted by Nitin Mehta <ni...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8900/#review15181
-----------------------------------------------------------
You need to take care of migration as well. Any thoughts on that ?
- Nitin Mehta
On Jan. 9, 2013, 7:29 a.m., saksham srivastava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8900/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2013, 7:29 a.m.)
>
>
> Review request for cloudstack and Devdeep Singh.
>
>
> Description
> -------
>
> Volumes created from snapshots misses the source template information.Fixed the issue with volumes now getting the template id.
>
>
> This addresses bug CLOUDSTACK-924.
>
>
> Diffs
> -----
>
> server/src/com/cloud/storage/StorageManagerImpl.java 96f299c
>
> Diff: https://reviews.apache.org/r/8900/diff/
>
>
> Testing
> -------
>
> Verified on local setup. from template1->instance->snapshot1->volume1->snapshot2->template2
> template2 now has source template id.
>
>
> Thanks,
>
> saksham srivastava
>
>