You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@uniffle.apache.org by GitBox <gi...@apache.org> on 2022/07/05 12:49:40 UTC

[GitHub] [incubator-uniffle] zuston commented on a diff in pull request #30: Allow to specify custom tags to decide data placement

zuston commented on code in PR #30:
URL: https://github.com/apache/incubator-uniffle/pull/30#discussion_r913759364


##########
server/src/main/java/org/apache/uniffle/server/ShuffleServer.java:
##########
@@ -262,7 +274,7 @@ public StorageManager getStorageManager() {
   }
 
   public Set<String> getTags() {
-    return tags;
+    return Collections.unmodifiableSet(tags);

Review Comment:
   I think this method is to return read -only tags. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org