(superset) branch john-bodley--fix-logging created (now 9f74bf92e2)

[jo...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

johnbodley pushed a change to branch john-bodley--fix-logging
in repository https://gitbox.apache.org/repos/asf/superset.git


      at 9f74bf92e2 fix(logging): Filter out undefined columns

This branch includes the following new commits:

     new 9f74bf92e2 fix(logging): Filter out undefined columns

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.

(superset) 01/01: fix(logging): Filter out undefined columns

[jo...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

johnbodley pushed a commit to branch john-bodley--fix-logging
in repository https://gitbox.apache.org/repos/asf/superset.git

commit 9f74bf92e2809cb2d75b87688553dfce7cf01a05
Author: John Bodley <45...@users.noreply.github.com>
AuthorDate: Wed Dec 20 14:19:21 2023 +1300

    fix(logging): Filter out undefined columns
---
 superset-frontend/src/dashboard/components/gridComponents/Chart.jsx | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/superset-frontend/src/dashboard/components/gridComponents/Chart.jsx b/superset-frontend/src/dashboard/components/gridComponents/Chart.jsx
index a99061c707..908874fe37 100644
--- a/superset-frontend/src/dashboard/components/gridComponents/Chart.jsx
+++ b/superset-frontend/src/dashboard/components/gridComponents/Chart.jsx
@@ -274,7 +274,9 @@ class Chart extends React.Component {
   changeFilter(newSelectedValues = {}) {
     this.props.logEvent(LOG_ACTIONS_CHANGE_DASHBOARD_FILTER, {
       id: this.props.chart.id,
-      columns: Object.keys(newSelectedValues),
+      columns: columns: Object.keys(newSelectedValues).filter(
+        key => newSelectedValues[key] !== null,
+      )
     });
     this.props.changeFilter(this.props.chart.id, newSelectedValues);
   }