You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/13 18:57:12 UTC

[GitHub] [arrow-datafusion] tustvold commented on a diff in pull request #2531: Fix size_of_scalar test

tustvold commented on code in PR #2531:
URL: https://github.com/apache/arrow-datafusion/pull/2531#discussion_r872697091


##########
datafusion/core/src/scalar.rs:
##########
@@ -377,7 +377,7 @@ mod tests {
         #[cfg(target_arch = "aarch64")]
         assert_eq!(std::mem::size_of::<ScalarValue>(), 64);
 
-        #[cfg(target_arch = "amd64")]
+        #[cfg(not(target_arch = "aarch64"))]

Review Comment:
   You could also write something like
   
   ```
   let expected = match cfg!(target_arch == "aarch64") {
     true => 64,
     false => 48,
   };
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org