You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by "sjanc (via GitHub)" <gi...@apache.org> on 2023/02/02 17:01:52 UTC
[GitHub] [mynewt-nimble] sjanc opened a new pull request, #1448: nimble/ll: Use MIN/MAX macros from ble_ll_utils.h
sjanc opened a new pull request, #1448:
URL: https://github.com/apache/mynewt-nimble/pull/1448
Use macros provided by utils instead of relying on system providing min and max macros.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] sjanc merged pull request #1448: nimble/ll: Use MIN/MAX macros from ble_ll_utils.h
Posted by "sjanc (via GitHub)" <gi...@apache.org>.
sjanc merged PR #1448:
URL: https://github.com/apache/mynewt-nimble/pull/1448
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] AxelLin commented on pull request #1448: nimble/ll: Use MIN/MAX macros from ble_ll_utils.h
Posted by "AxelLin (via GitHub)" <gi...@apache.org>.
AxelLin commented on PR #1448:
URL: https://github.com/apache/mynewt-nimble/pull/1448#issuecomment-1445933875
Hi,
There are many min()/max() usage in nimble/host, nimble/transport, etc. (Not just in nimble/controller)
And there are so many duplicate code as :
https://github.com/apache/mynewt-nimble/blob/master/nimble/host/src/ble_att.c#L27-L33
https://github.com/apache/mynewt-nimble/blob/master/nimble/host/src/ble_gap.c#L30-L36
https://github.com/apache/mynewt-nimble/blob/master/porting/nimble/src/os_mbuf.c#L44-L50
Do you consider to put MIN/MAX macros at a common header file and replace all the min()/max() calls?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] sjanc commented on pull request #1448: nimble/ll: Use MIN/MAX macros from ble_ll_utils.h
Posted by "sjanc (via GitHub)" <gi...@apache.org>.
sjanc commented on PR #1448:
URL: https://github.com/apache/mynewt-nimble/pull/1448#issuecomment-1445976560
yes, we will clean it up eventually (this PR was to handle LL code only)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org