You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Blair Zajac <bl...@orcaware.com> on 2002/11/09 03:05:42 UTC
[PATCH] fix issue #976
Can somebody review this small patch? Especially the python test,
which I haven't gotten to work.
Best,
Blair
--
Blair Zajac <bl...@orcaware.com>
Web and OS performance plots - http://www.orcaware.com/orca/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] fix issue #976
Posted by Blair Zajac <bl...@orcaware.com>.
And here's the patch.
Blair
Re: [PATCH] fix issue #976
Posted by Blair Zajac <bl...@orcaware.com>.
Karl Fogel wrote:
>
> Blair Zajac <bl...@orcaware.com> writes:
> > Well, it turns out that
> > svntest.main.actions.run_and_verify_commit
> > doesn't take an expected_disk argument, so I need to find another
> > way to check the properties on the file after an svn cp.
> >
> > I could do the commit and then use
> > svntest.actions.run_and_verify_update
> > which would be an empty update to check the properties.
> >
> > What's the best way to do this.
>
> Maybe just check the properties directly? :-) That is, run propget and
> examine the output.
OK. I'll do the check that way.
>
> > BTW, should run_and_verify_commit be modified to take an expected
> > disk structure?
>
> I'm not sure it's worth it for this one thing. Are there other places
> where we'd like to do that?
Probably not.
Blair
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] fix issue #976
Posted by Karl Fogel <kf...@newton.ch.collab.net>.
Blair Zajac <bl...@orcaware.com> writes:
> Well, it turns out that
> svntest.main.actions.run_and_verify_commit
> doesn't take an expected_disk argument, so I need to find another
> way to check the properties on the file after an svn cp.
>
> I could do the commit and then use
> svntest.actions.run_and_verify_update
> which would be an empty update to check the properties.
>
> What's the best way to do this.
Maybe just check the properties directly? :-) That is, run propget and
examine the output.
> BTW, should run_and_verify_commit be modified to take an expected
> disk structure?
I'm not sure it's worth it for this one thing. Are there other places
where we'd like to do that?
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] fix issue #976
Posted by Blair Zajac <bl...@orcaware.com>.
Karl Fogel wrote:
>
> Blair Zajac <bl...@orcaware.com> writes:
> > Can somebody review this small patch? Especially the python test,
> > which I haven't gotten to work.
>
> Looks great to me.
>
> Did you try Brane's solution for the regression test yet? He
> recommended using
>
> expected_disk.add({'new_file2.bin' :
> Item(props={'svn:mime-type' : orig_mime_type})})
>
> in the obvious spot. I haven't tried it, but it ought to work.
>
> Assume you'll commit this if it all works. Do post if have any
> problems, there's no reason we can't get this issue klonked today :-).
Well, it turns out that
svntest.main.actions.run_and_verify_commit
doesn't take an expected_disk argument, so I need to find another
way to check the properties on the file after an svn cp.
I could do the commit and then use
svntest.actions.run_and_verify_update
which would be an empty update to check the properties.
What's the best way to do this.
BTW, should run_and_verify_commit be modified to take an expected
disk structure?
Blair
--
Blair Zajac <bl...@orcaware.com>
Web and OS performance plots - http://www.orcaware.com/orca/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] fix issue #976
Posted by Karl Fogel <kf...@newton.ch.collab.net>.
Blair Zajac <bl...@orcaware.com> writes:
> Can somebody review this small patch? Especially the python test,
> which I haven't gotten to work.
Looks great to me.
Did you try Brane's solution for the regression test yet? He
recommended using
expected_disk.add({'new_file2.bin' :
Item(props={'svn:mime-type' : orig_mime_type})})
in the obvious spot. I haven't tried it, but it ought to work.
Assume you'll commit this if it all works. Do post if have any
problems, there's no reason we can't get this issue klonked today :-).
-K
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org