You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Shlomi Fish <sh...@vipe.stud.technion.ac.il> on 2003/08/10 08:42:27 UTC
My Unapplied Patches [was Re: [PATCH] Issue #1297 Fix - Rev. 5]
OK, I removed the patches that were already applied from my patches
directory, and now it contains only unapplied patches (4 of them so far).
The URL is as always:
http://t2.technion.ac.il/~shlomif/svn-patches/
Regards,
Shlomi Fish
----------------------------------------------------------------------
Shlomi Fish shlomif@vipe.technion.ac.il
Home Page: http://t2.technion.ac.il/~shlomif/
An apple a day will keep a doctor away. Two apples a day will keep two
doctors away.
Falk Fish
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: My Unapplied Patches [was Re: [PATCH] Issue #1297 Fix - Rev. 5]
Posted by kf...@collab.net.
Shlomi Fish <sh...@vipe.stud.technion.ac.il> writes:
> Yes, but when I update the patch, if I invoke svn diff >> logfile.txt on
> the existing log+patch file, I'll get a second patch appended to the file.
> OTOH, if I do svn diff > patch.txt, I will overwrite the patch.
Look, it's no big deal.
If you find it *that* inconvenient to put the patch and the log
message in the same file, then use two :-). I'm just indicating
what's easiest for us consumers (remember, there are N consumers for
every 1 producer; something to think about when evaluating the
cost/benefit of packing things conveniently for the consumers).
-K
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: My Unapplied Patches [was Re: [PATCH] Issue #1297 Fix - Rev. 5]
Posted by Shlomi Fish <sh...@vipe.stud.technion.ac.il>.
On Mon, 11 Aug 2003, John Peacock wrote:
> Shlomi Fish wrote:
>
> >
> > Oh OK. It's still easier for me to maintain the files my way, because then
> > I can simply redirect svn diff to the file and write the log in a separate
> > message.
> >
>
> Write the log message as you go (good policy, since you don't forget anything),
> then 'svn diff ... >> logfile.txt' when you are ready to submit. TMTOWTDI
>
Yes, but when I update the patch, if I invoke svn diff >> logfile.txt on
the existing log+patch file, I'll get a second patch appended to the file.
OTOH, if I do svn diff > patch.txt, I will overwrite the patch.
Regards,
Shlomi Fish
> John
>
>
----------------------------------------------------------------------
Shlomi Fish shlomif@vipe.technion.ac.il
Home Page: http://t2.technion.ac.il/~shlomif/
An apple a day will keep a doctor away. Two apples a day will keep two
doctors away.
Falk Fish
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: My Unapplied Patches [was Re: [PATCH] Issue #1297 Fix - Rev.
5]
Posted by John Peacock <jp...@rowman.com>.
Shlomi Fish wrote:
>
> Oh OK. It's still easier for me to maintain the files my way, because then
> I can simply redirect svn diff to the file and write the log in a separate
> message.
>
Write the log message as you go (good policy, since you don't forget anything),
then 'svn diff ... >> logfile.txt' when you are ready to submit. TMTOWTDI
John
--
John Peacock
Director of Information Research and Technology
Rowman & Littlefield Publishing Group
4501 Forbes Boulevard
Suite H
Lanham, MD 20706
301-459-3366 x.5010
fax 301-429-5748
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: My Unapplied Patches [was Re: [PATCH] Issue #1297 Fix - Rev. 5]
Posted by Shlomi Fish <sh...@vipe.stud.technion.ac.il>.
On Mon, 11 Aug 2003 kfogel@collab.net wrote:
> Shlomi Fish <sh...@vipe.stud.technion.ac.il> writes:
> > I'd rather not. It makes it more difficult to apply the patch.
>
> Have you tried it? :-) The 'patch' program just ignores the non-patch
> portion.
>
Oh OK. It's still easier for me to maintain the files my way, because then
I can simply redirect svn diff to the file and write the log in a separate
message.
> > add-config-dir.patch.txt and add-config-dir.log.txt are no longer valid
> > and rather broken.
>
> Then no reason to keep them in the dir...
>
Removed.
> > Use add-config-dir-rev2. What this patch does is add
> > a --config-dir option to the command line clients (and underlying
> > libraries) to specify an alternative directory where one can find the
> > configuration files. It helps for Issue #1385:
> >
> > http://subversion.tigris.org/issues/show_bug.cgi?id=1385
> >
> > and may be usable in other cases.
>
> Thanks. I'd recommend just naming the patch after 1385, and making a
> comment in the issue.
>
There is already a comment in the issue. I added an issue-1385.html file
that links to the patch and log of add-config-dir.
Regards,
Shlomi Fish
----------------------------------------------------------------------
Shlomi Fish shlomif@vipe.technion.ac.il
Home Page: http://t2.technion.ac.il/~shlomif/
An apple a day will keep a doctor away. Two apples a day will keep two
doctors away.
Falk Fish
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: My Unapplied Patches [was Re: [PATCH] Issue #1297 Fix - Rev. 5]
Posted by kf...@collab.net.
Shlomi Fish <sh...@vipe.stud.technion.ac.il> writes:
> I'd rather not. It makes it more difficult to apply the patch.
Have you tried it? :-) The 'patch' program just ignores the non-patch
portion.
> add-config-dir.patch.txt and add-config-dir.log.txt are no longer valid
> and rather broken.
Then no reason to keep them in the dir...
> Use add-config-dir-rev2. What this patch does is add
> a --config-dir option to the command line clients (and underlying
> libraries) to specify an alternative directory where one can find the
> configuration files. It helps for Issue #1385:
>
> http://subversion.tigris.org/issues/show_bug.cgi?id=1385
>
> and may be usable in other cases.
Thanks. I'd recommend just naming the patch after 1385, and making a
comment in the issue.
-Karl
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
RE: My Unapplied Patches [was Re: [PATCH] Issue #1297 Fix - Rev. 5]
Posted by Sander Striker <st...@apache.org>.
> From: Shlomi Fish [mailto:shlomif@vipe.technion.ac.il]
> Sent: Monday, August 11, 2003 5:40 PM
> On Mon, 11 Aug 2003 kfogel@collab.net wrote:
>> 1) Put log message and patch in the same file, so there's exactly
>> one file per patch.
>
> I'd rather not. It makes it more difficult to apply the patch.
Not it doesn't. 'patch' is very well capable of ignoring non patch parts.
Sander
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: My Unapplied Patches [was Re: [PATCH] Issue #1297 Fix - Rev. 5]
Posted by Shlomi Fish <sh...@vipe.stud.technion.ac.il>.
On Mon, 11 Aug 2003 kfogel@collab.net wrote:
> Shlomi Fish <sh...@vipe.stud.technion.ac.il> writes:
> > OK, I removed the patches that were already applied from my patches
> > directory, and now it contains only unapplied patches (4 of them so far).
> >
> > The URL is as always:
> >
> > http://t2.technion.ac.il/~shlomif/svn-patches/
>
> Thanks, I took a look. A couple of quick suggestions:
>
> 1) Put log message and patch in the same file, so there's exactly
> one file per patch.
>
I'd rather not. It makes it more difficult to apply the patch.
> 2) When the patch is for an issue, make a note in the issue
> giving the URL for the (single) patch file.
>
OK.
> Regarding the specific patches:
>
> Are these for an open issue?:
>
> add-config-dir-rev2...> 10-Aug-2003 11:40 2k
> add-config-dir-rev2...> 10-Aug-2003 11:40 36k
> add-config-dir.log.txt 10-Aug-2003 11:40 1k
> add-config-dir.patch..> 10-Aug-2003 11:40 23k
>
add-config-dir.patch.txt and add-config-dir.log.txt are no longer valid
and rather broken. Use add-config-dir-rev2. What this patch does is add
a --config-dir option to the command line clients (and underlying
libraries) to specify an alternative directory where one can find the
configuration files. It helps for Issue #1385:
http://subversion.tigris.org/issues/show_bug.cgi?id=1385
and may be usable in other cases.
> This one is for a Post-1.0 issue (the patch looks good to me, by the
> way; I'd like for Sander Striker, Justin Erenkrantz, or some other
> APR/Apache/HTTP-knowledgeable person to glance at it, but I think it
> can & should be applied):
>
> issue-1209-fix.log.txt 10-Aug-2003 11:40 1k
> issue-1209-fix.patch..> 10-Aug-2003 11:40 1k
>
> This issue is closed, MBK has applied your patch:
>
> issue-1266-fix.log.txt 10-Aug-2003 11:40 1k
> issue-1266-fix.patch..> 10-Aug-2003 11:40 1k
>
So I see. OK, I'll remove them from the collection.
> This issue is assigned to me, so I'll review your patch right away
> (and I'll link to your patch in the issue, you don't need to do it):
>
> issue-1313-fix.log.txt 10-Aug-2003 11:40 1k
> issue-1313-fix.patch..> 10-Aug-2003 11:40 3k
>
OK.
> Thanks,
> -Karl
>
----------------------------------------------------------------------
Shlomi Fish shlomif@vipe.technion.ac.il
Home Page: http://t2.technion.ac.il/~shlomif/
An apple a day will keep a doctor away. Two apples a day will keep two
doctors away.
Falk Fish
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: My Unapplied Patches [was Re: [PATCH] Issue #1297 Fix - Rev. 5]
Posted by kf...@collab.net.
Shlomi Fish <sh...@vipe.stud.technion.ac.il> writes:
> OK, I removed the patches that were already applied from my patches
> directory, and now it contains only unapplied patches (4 of them so far).
>
> The URL is as always:
>
> http://t2.technion.ac.il/~shlomif/svn-patches/
Thanks, I took a look. A couple of quick suggestions:
1) Put log message and patch in the same file, so there's exactly
one file per patch.
2) When the patch is for an issue, make a note in the issue
giving the URL for the (single) patch file.
Regarding the specific patches:
Are these for an open issue?:
add-config-dir-rev2...> 10-Aug-2003 11:40 2k
add-config-dir-rev2...> 10-Aug-2003 11:40 36k
add-config-dir.log.txt 10-Aug-2003 11:40 1k
add-config-dir.patch..> 10-Aug-2003 11:40 23k
This one is for a Post-1.0 issue (the patch looks good to me, by the
way; I'd like for Sander Striker, Justin Erenkrantz, or some other
APR/Apache/HTTP-knowledgeable person to glance at it, but I think it
can & should be applied):
issue-1209-fix.log.txt 10-Aug-2003 11:40 1k
issue-1209-fix.patch..> 10-Aug-2003 11:40 1k
This issue is closed, MBK has applied your patch:
issue-1266-fix.log.txt 10-Aug-2003 11:40 1k
issue-1266-fix.patch..> 10-Aug-2003 11:40 1k
This issue is assigned to me, so I'll review your patch right away
(and I'll link to your patch in the issue, you don't need to do it):
issue-1313-fix.log.txt 10-Aug-2003 11:40 1k
issue-1313-fix.patch..> 10-Aug-2003 11:40 3k
Thanks,
-Karl
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org