You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by Thomas Koch <th...@koch.ro> on 2011/09/22 13:14:31 UTC
Review Request: ZOOKEEPER-1199: Make OpCode an enum
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2015/
-----------------------------------------------------------
Review request for zookeeper.
Summary
-------
There are four places in the ZK code, that mapped OpCodes to string representations. One of them wasn't used anymore, two others represented the same mapping and the last one provided four letter representations. As you can see in the definition of the OpCode enum, there were strings missing for some newer added OpCodes. You might want to say, which strings I should put in?
I spotted an inconsistency in server/quorum/ReadOnlyRequestProcessor.java. There's a switch checking for a write operation which does not include multi, start- and stopsession. What is intended there?
This addresses bug ZOOKEEPER-1199.
https://issues.apache.org/jira/browse/ZOOKEEPER-1199
Diffs
-----
src/java/main/org/apache/zookeeper/ClientCnxn.java db15348
src/java/main/org/apache/zookeeper/ClientCnxnSocketNIO.java 017ab14
src/java/main/org/apache/zookeeper/MultiResponse.java 97d4c7d
src/java/main/org/apache/zookeeper/MultiTransactionRecord.java af3b58d
src/java/main/org/apache/zookeeper/Op.java 3c3db2e
src/java/main/org/apache/zookeeper/OpResult.java 514318f
src/java/main/org/apache/zookeeper/ZooDefs.java c7f1b20
src/java/main/org/apache/zookeeper/ZooKeeper.java e82eaa0
src/java/main/org/apache/zookeeper/client/ZooKeeperSaslClient.java 43382c8
src/java/main/org/apache/zookeeper/server/DataTree.java 3d0b3c4
src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java c746299
src/java/main/org/apache/zookeeper/server/LogFormatter.java 9be3fe3
src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java 9e55c7b
src/java/main/org/apache/zookeeper/server/Request.java 53631f1
src/java/main/org/apache/zookeeper/server/ServerCnxn.java 6dd509b
src/java/main/org/apache/zookeeper/server/TraceFormatter.java 60d1cc7
src/java/main/org/apache/zookeeper/server/ZKDatabase.java 92f475b
src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java 9ccaa0e
src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java fec70de
src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java a0c2cbd
src/java/main/org/apache/zookeeper/server/quorum/FollowerRequestProcessor.java a1c8ce2
src/java/main/org/apache/zookeeper/server/quorum/FollowerZooKeeperServer.java 95c77b5
src/java/main/org/apache/zookeeper/server/quorum/Learner.java a97a543
src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java c518792
src/java/main/org/apache/zookeeper/server/quorum/LearnerSyncRequest.java bfbc9a8
src/java/main/org/apache/zookeeper/server/quorum/Observer.java 2e15a81
src/java/main/org/apache/zookeeper/server/quorum/ObserverRequestProcessor.java e94414f
src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyRequestProcessor.java 82d1468
src/java/main/org/apache/zookeeper/server/upgrade/DataTreeV1.java 8559451
src/java/main/org/apache/zookeeper/server/upgrade/UpgradeSnapShotV1.java 1ca9f9a
src/java/main/org/apache/zookeeper/server/util/SerializeUtils.java f9647c4
src/java/test/org/apache/zookeeper/server/quorum/LearnerTest.java e37cbec
src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java be29939
src/java/test/org/apache/zookeeper/test/LoadFromLogTest.java a134210
Diff: https://reviews.apache.org/r/2015/diff
Testing
-------
Thanks,
Thomas
Re: Review Request: ZOOKEEPER-1199: Make OpCode an enum
Posted by Thomas Koch <th...@koch.ro>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2015/
-----------------------------------------------------------
(Updated 2011-10-25 16:51:47.887909)
Review request for zookeeper.
Changes
-------
centralized the logic to deserialize requests in PrepRequestProcessor and FinalRequestProcessor
Summary
-------
There are four places in the ZK code, that mapped OpCodes to string representations. One of them wasn't used anymore, two others represented the same mapping and the last one provided four letter representations. As you can see in the definition of the OpCode enum, there were strings missing for some newer added OpCodes. You might want to say, which strings I should put in?
I spotted an inconsistency in server/quorum/ReadOnlyRequestProcessor.java. There's a switch checking for a write operation which does not include multi, start- and stopsession. What is intended there?
This addresses bug ZOOKEEPER-1199.
https://issues.apache.org/jira/browse/ZOOKEEPER-1199
Diffs (updated)
-----
src/contrib/loggraph/src/java/org/apache/zookeeper/graph/TxnLogSource.java 809c455
src/java/main/org/apache/zookeeper/ClientCnxn.java 6c25e40
src/java/main/org/apache/zookeeper/ClientCnxnSocketNIO.java 9216751
src/java/main/org/apache/zookeeper/MultiResponse.java 97d4c7d
src/java/main/org/apache/zookeeper/MultiTransactionRecord.java af3b58d
src/java/main/org/apache/zookeeper/Op.java 3c3db2e
src/java/main/org/apache/zookeeper/OpResult.java 514318f
src/java/main/org/apache/zookeeper/ZooDefs.java c7f1b20
src/java/main/org/apache/zookeeper/ZooKeeper.java e82eaa0
src/java/main/org/apache/zookeeper/client/ZooKeeperSaslClient.java 722538e
src/java/main/org/apache/zookeeper/server/DataTree.java 757a572
src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java 336827a
src/java/main/org/apache/zookeeper/server/LogFormatter.java 9be3fe3
src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java e44c65e
src/java/main/org/apache/zookeeper/server/Request.java c6a2249
src/java/main/org/apache/zookeeper/server/ServerCnxn.java 6dd509b
src/java/main/org/apache/zookeeper/server/TraceFormatter.java 60d1cc7
src/java/main/org/apache/zookeeper/server/ZKDatabase.java 2842803
src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java 9ccaa0e
src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java 938cf19
src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java 2f77e9d
src/java/main/org/apache/zookeeper/server/quorum/FollowerRequestProcessor.java a1c8ce2
src/java/main/org/apache/zookeeper/server/quorum/FollowerZooKeeperServer.java 27bf496
src/java/main/org/apache/zookeeper/server/quorum/Learner.java a97a543
src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java 2d0714f
src/java/main/org/apache/zookeeper/server/quorum/LearnerSyncRequest.java bfbc9a8
src/java/main/org/apache/zookeeper/server/quorum/Observer.java 8e77ac8
src/java/main/org/apache/zookeeper/server/quorum/ObserverRequestProcessor.java e94414f
src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyRequestProcessor.java 82d1468
src/java/main/org/apache/zookeeper/server/util/SerializeUtils.java f9647c4
src/java/test/org/apache/zookeeper/common/OpCodeTest.java PRE-CREATION
src/java/test/org/apache/zookeeper/server/quorum/LearnerTest.java e37cbec
src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java 38a3c57
src/java/test/org/apache/zookeeper/test/LoadFromLogTest.java a134210
Diff: https://reviews.apache.org/r/2015/diff
Testing
-------
Thanks,
Thomas
Re: Review Request: ZOOKEEPER-1199: Make OpCode an enum
Posted by Thomas Koch <th...@koch.ro>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2015/
-----------------------------------------------------------
(Updated 2011-10-24 17:44:19.879262)
Review request for zookeeper.
Summary
-------
There are four places in the ZK code, that mapped OpCodes to string representations. One of them wasn't used anymore, two others represented the same mapping and the last one provided four letter representations. As you can see in the definition of the OpCode enum, there were strings missing for some newer added OpCodes. You might want to say, which strings I should put in?
I spotted an inconsistency in server/quorum/ReadOnlyRequestProcessor.java. There's a switch checking for a write operation which does not include multi, start- and stopsession. What is intended there?
This addresses bug ZOOKEEPER-1199.
https://issues.apache.org/jira/browse/ZOOKEEPER-1199
Diffs (updated)
-----
src/contrib/loggraph/src/java/org/apache/zookeeper/graph/TxnLogSource.java 809c455
src/java/main/org/apache/zookeeper/ClientCnxn.java 6c25e40
src/java/main/org/apache/zookeeper/ClientCnxnSocketNIO.java 9216751
src/java/main/org/apache/zookeeper/MultiResponse.java 97d4c7d
src/java/main/org/apache/zookeeper/MultiTransactionRecord.java af3b58d
src/java/main/org/apache/zookeeper/Op.java 3c3db2e
src/java/main/org/apache/zookeeper/OpResult.java 514318f
src/java/main/org/apache/zookeeper/ZooDefs.java c7f1b20
src/java/main/org/apache/zookeeper/ZooKeeper.java e82eaa0
src/java/main/org/apache/zookeeper/client/ZooKeeperSaslClient.java 722538e
src/java/main/org/apache/zookeeper/server/DataTree.java 757a572
src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java 336827a
src/java/main/org/apache/zookeeper/server/LogFormatter.java 9be3fe3
src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java e44c65e
src/java/main/org/apache/zookeeper/server/Request.java c6a2249
src/java/main/org/apache/zookeeper/server/ServerCnxn.java 6dd509b
src/java/main/org/apache/zookeeper/server/TraceFormatter.java 60d1cc7
src/java/main/org/apache/zookeeper/server/ZKDatabase.java 2842803
src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java 9ccaa0e
src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java 938cf19
src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java 2f77e9d
src/java/main/org/apache/zookeeper/server/quorum/FollowerRequestProcessor.java a1c8ce2
src/java/main/org/apache/zookeeper/server/quorum/FollowerZooKeeperServer.java 27bf496
src/java/main/org/apache/zookeeper/server/quorum/Learner.java a97a543
src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java c518792
src/java/main/org/apache/zookeeper/server/quorum/LearnerSyncRequest.java bfbc9a8
src/java/main/org/apache/zookeeper/server/quorum/Observer.java 8e77ac8
src/java/main/org/apache/zookeeper/server/quorum/ObserverRequestProcessor.java e94414f
src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyRequestProcessor.java 82d1468
src/java/main/org/apache/zookeeper/server/util/SerializeUtils.java f9647c4
src/java/test/org/apache/zookeeper/common/OpCodeTest.java PRE-CREATION
src/java/test/org/apache/zookeeper/server/quorum/LearnerTest.java e37cbec
src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java 7a5a75b
src/java/test/org/apache/zookeeper/test/LoadFromLogTest.java a134210
Diff: https://reviews.apache.org/r/2015/diff
Testing
-------
Thanks,
Thomas