You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/03/03 19:55:53 UTC
[GitHub] [geode] dschneider-pivotal opened a new pull request #6083: GEODE-8998: fix NPE caused by thread-monitor-enabled=false
dschneider-pivotal opened a new pull request #6083:
URL: https://github.com/apache/geode/pull/6083
The P2PReaderExecutorGroup is now called directly since the p2p reader always needs
a non-null instance. When thread monitoring is disabled, the p2p reader will still call
suspend and resume even though the P2PReaderExecutorGroup is not being monitored.
But these calls are very cheap so it is better to call them instead of doing a bunch of
null checks.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] dschneider-pivotal commented on a change in pull request #6083: GEODE-8998: fix NPE caused by thread-monitor-enabled=false
Posted by GitBox <gi...@apache.org>.
dschneider-pivotal commented on a change in pull request #6083:
URL: https://github.com/apache/geode/pull/6083#discussion_r586860552
##########
File path: geode-core/src/main/java/org/apache/geode/internal/monitoring/ThreadsMonitoringImplDummy.java
##########
@@ -32,9 +32,17 @@ public boolean startMonitor(Mode mode) {
@Override
public void endMonitor() {}
+ private static class DummyAbstractExecutor extends AbstractExecutor {
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] Bill commented on a change in pull request #6083: GEODE-8998: fix NPE caused by thread-monitor-enabled=false
Posted by GitBox <gi...@apache.org>.
Bill commented on a change in pull request #6083:
URL: https://github.com/apache/geode/pull/6083#discussion_r586849213
##########
File path: geode-core/src/main/java/org/apache/geode/internal/monitoring/ThreadsMonitoringImplDummy.java
##########
@@ -32,9 +32,17 @@ public boolean startMonitor(Mode mode) {
@Override
public void endMonitor() {}
+ private static class DummyAbstractExecutor extends AbstractExecutor {
+ private static final DummyAbstractExecutor SINGLETON = new DummyAbstractExecutor();
+
+ private DummyAbstractExecutor() {
+ super("dummyExecutorGroup", 0L);
Review comment:
From looking at other group names they are typically capitalized like class names and don't end in the word `Group`. So I recommend:
`"DummyExecutor"`
##########
File path: geode-core/src/main/java/org/apache/geode/internal/monitoring/ThreadsMonitoringImplDummy.java
##########
@@ -32,9 +32,17 @@ public boolean startMonitor(Mode mode) {
@Override
public void endMonitor() {}
+ private static class DummyAbstractExecutor extends AbstractExecutor {
Review comment:
I think this new class is not meant to be subclassed so I recommend removing `Abstract` from the name.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] dschneider-pivotal merged pull request #6083: GEODE-8998: fix NPE caused by thread-monitor-enabled=false
Posted by GitBox <gi...@apache.org>.
dschneider-pivotal merged pull request #6083:
URL: https://github.com/apache/geode/pull/6083
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] dschneider-pivotal commented on a change in pull request #6083: GEODE-8998: fix NPE caused by thread-monitor-enabled=false
Posted by GitBox <gi...@apache.org>.
dschneider-pivotal commented on a change in pull request #6083:
URL: https://github.com/apache/geode/pull/6083#discussion_r586860430
##########
File path: geode-core/src/main/java/org/apache/geode/internal/monitoring/ThreadsMonitoringImplDummy.java
##########
@@ -32,9 +32,17 @@ public boolean startMonitor(Mode mode) {
@Override
public void endMonitor() {}
+ private static class DummyAbstractExecutor extends AbstractExecutor {
+ private static final DummyAbstractExecutor SINGLETON = new DummyAbstractExecutor();
+
+ private DummyAbstractExecutor() {
+ super("dummyExecutorGroup", 0L);
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org