You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/02/07 10:05:29 UTC
[GitHub] [hudi] YannByron opened a new pull request #4758: [HUDI-2610] pass the spark version when sync the table created by spark
YannByron opened a new pull request #4758:
URL: https://github.com/apache/hudi/pull/4758
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.*
## What is the purpose of the pull request
*(For example: This pull request adds quick-start document.)*
## Brief change log
*(for example:)*
- *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4758: [HUDI-2610] pass the spark version when sync the table created by spark
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4758:
URL: https://github.com/apache/hudi/pull/4758#issuecomment-1033733952
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9e43f9f8b6c53222184b37a79faba04d7fa2e720",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5756",
"triggerID" : "9e43f9f8b6c53222184b37a79faba04d7fa2e720",
"triggerType" : "PUSH"
}, {
"hash" : "34313bf363083d33410d19fbe3145f852aff7447",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "34313bf363083d33410d19fbe3145f852aff7447",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9e43f9f8b6c53222184b37a79faba04d7fa2e720 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5756)
* 34313bf363083d33410d19fbe3145f852aff7447 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4758: [HUDI-2610] pass the spark version when sync the table created by spark
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4758:
URL: https://github.com/apache/hudi/pull/4758#issuecomment-1033736459
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9e43f9f8b6c53222184b37a79faba04d7fa2e720",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5756",
"triggerID" : "9e43f9f8b6c53222184b37a79faba04d7fa2e720",
"triggerType" : "PUSH"
}, {
"hash" : "34313bf363083d33410d19fbe3145f852aff7447",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5840",
"triggerID" : "34313bf363083d33410d19fbe3145f852aff7447",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9e43f9f8b6c53222184b37a79faba04d7fa2e720 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5756)
* 34313bf363083d33410d19fbe3145f852aff7447 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5840)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4758: [HUDI-2610] pass the spark version when sync the table created by spark
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4758:
URL: https://github.com/apache/hudi/pull/4758#issuecomment-1031287617
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9e43f9f8b6c53222184b37a79faba04d7fa2e720",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9e43f9f8b6c53222184b37a79faba04d7fa2e720",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9e43f9f8b6c53222184b37a79faba04d7fa2e720 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] YannByron commented on pull request #4758: [HUDI-2610] pass the spark version when sync the table created by spark
Posted by GitBox <gi...@apache.org>.
YannByron commented on pull request #4758:
URL: https://github.com/apache/hudi/pull/4758#issuecomment-1033822167
@hudi-bot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4758: [HUDI-2610] pass the spark version when sync the table created by spark
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4758:
URL: https://github.com/apache/hudi/pull/4758#issuecomment-1033802773
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9e43f9f8b6c53222184b37a79faba04d7fa2e720",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5756",
"triggerID" : "9e43f9f8b6c53222184b37a79faba04d7fa2e720",
"triggerType" : "PUSH"
}, {
"hash" : "34313bf363083d33410d19fbe3145f852aff7447",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5840",
"triggerID" : "34313bf363083d33410d19fbe3145f852aff7447",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 34313bf363083d33410d19fbe3145f852aff7447 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5840)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] YannByron commented on a change in pull request #4758: [HUDI-2610] pass the spark version when sync the table created by spark
Posted by GitBox <gi...@apache.org>.
YannByron commented on a change in pull request #4758:
URL: https://github.com/apache/hudi/pull/4758#discussion_r800719326
##########
File path: hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/HiveSyncTool.java
##########
@@ -302,6 +303,9 @@ private boolean syncSchema(String tableName, boolean tableExists, boolean useRea
Map<String, String> sparkProperties = new HashMap<>();
sparkProperties.put("spark.sql.sources.provider", "hudi");
+ if (!StringUtils.isNullOrEmpty(cfg.sparkVersion)) {
+ sparkProperties.put("spark.sql.create.version", cfg.sparkVersion);
Review comment:
see the description of the related ticket. Spark will use this config when execute `desc formatted`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4758: [HUDI-2610] pass the spark version when sync the table created by spark
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4758:
URL: https://github.com/apache/hudi/pull/4758#issuecomment-1033733952
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9e43f9f8b6c53222184b37a79faba04d7fa2e720",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5756",
"triggerID" : "9e43f9f8b6c53222184b37a79faba04d7fa2e720",
"triggerType" : "PUSH"
}, {
"hash" : "34313bf363083d33410d19fbe3145f852aff7447",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "34313bf363083d33410d19fbe3145f852aff7447",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9e43f9f8b6c53222184b37a79faba04d7fa2e720 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5756)
* 34313bf363083d33410d19fbe3145f852aff7447 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] YannByron commented on a change in pull request #4758: [HUDI-2610] pass the spark version when sync the table created by spark
Posted by GitBox <gi...@apache.org>.
YannByron commented on a change in pull request #4758:
URL: https://github.com/apache/hudi/pull/4758#discussion_r802631754
##########
File path: hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieSparkSqlWriter.scala
##########
@@ -573,6 +575,7 @@ object HoodieSparkSqlWriter {
hiveSyncConfig.syncMode = hoodieConfig.getString(HIVE_SYNC_MODE)
hiveSyncConfig.serdeProperties = hoodieConfig.getString(HIVE_TABLE_SERDE_PROPERTIES)
hiveSyncConfig.tableProperties = hoodieConfig.getString(HIVE_TABLE_PROPERTIES)
+ hiveSyncConfig.sparkVersion = SPARK_VERSION
Review comment:
Thanks for your remind. And i've updated here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4758: [HUDI-2610] pass the spark version when sync the table created by spark
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4758:
URL: https://github.com/apache/hudi/pull/4758#issuecomment-1033955656
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9e43f9f8b6c53222184b37a79faba04d7fa2e720",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5756",
"triggerID" : "9e43f9f8b6c53222184b37a79faba04d7fa2e720",
"triggerType" : "PUSH"
}, {
"hash" : "34313bf363083d33410d19fbe3145f852aff7447",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5840",
"triggerID" : "34313bf363083d33410d19fbe3145f852aff7447",
"triggerType" : "PUSH"
}, {
"hash" : "34313bf363083d33410d19fbe3145f852aff7447",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5844",
"triggerID" : "1033822167",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 34313bf363083d33410d19fbe3145f852aff7447 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5840) Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5844)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codope merged pull request #4758: [HUDI-2610] pass the spark version when sync the table created by spark
Posted by GitBox <gi...@apache.org>.
codope merged pull request #4758:
URL: https://github.com/apache/hudi/pull/4758
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4758: [HUDI-2610] pass the spark version when sync the table created by spark
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4758:
URL: https://github.com/apache/hudi/pull/4758#issuecomment-1033736459
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9e43f9f8b6c53222184b37a79faba04d7fa2e720",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5756",
"triggerID" : "9e43f9f8b6c53222184b37a79faba04d7fa2e720",
"triggerType" : "PUSH"
}, {
"hash" : "34313bf363083d33410d19fbe3145f852aff7447",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5840",
"triggerID" : "34313bf363083d33410d19fbe3145f852aff7447",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9e43f9f8b6c53222184b37a79faba04d7fa2e720 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5756)
* 34313bf363083d33410d19fbe3145f852aff7447 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5840)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4758: [HUDI-2610] pass the spark version when sync the table created by spark
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4758:
URL: https://github.com/apache/hudi/pull/4758#issuecomment-1033824535
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9e43f9f8b6c53222184b37a79faba04d7fa2e720",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5756",
"triggerID" : "9e43f9f8b6c53222184b37a79faba04d7fa2e720",
"triggerType" : "PUSH"
}, {
"hash" : "34313bf363083d33410d19fbe3145f852aff7447",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5840",
"triggerID" : "34313bf363083d33410d19fbe3145f852aff7447",
"triggerType" : "PUSH"
}, {
"hash" : "34313bf363083d33410d19fbe3145f852aff7447",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5844",
"triggerID" : "1033822167",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 34313bf363083d33410d19fbe3145f852aff7447 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5840) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5844)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4758: [HUDI-2610] pass the spark version when sync the table created by spark
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4758:
URL: https://github.com/apache/hudi/pull/4758#issuecomment-1033824535
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9e43f9f8b6c53222184b37a79faba04d7fa2e720",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5756",
"triggerID" : "9e43f9f8b6c53222184b37a79faba04d7fa2e720",
"triggerType" : "PUSH"
}, {
"hash" : "34313bf363083d33410d19fbe3145f852aff7447",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5840",
"triggerID" : "34313bf363083d33410d19fbe3145f852aff7447",
"triggerType" : "PUSH"
}, {
"hash" : "34313bf363083d33410d19fbe3145f852aff7447",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5844",
"triggerID" : "1033822167",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 34313bf363083d33410d19fbe3145f852aff7447 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5840) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5844)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4758: [HUDI-2610] pass the spark version when sync the table created by spark
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4758:
URL: https://github.com/apache/hudi/pull/4758#issuecomment-1031370127
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9e43f9f8b6c53222184b37a79faba04d7fa2e720",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5756",
"triggerID" : "9e43f9f8b6c53222184b37a79faba04d7fa2e720",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9e43f9f8b6c53222184b37a79faba04d7fa2e720 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5756)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4758: [HUDI-2610] pass the spark version when sync the table created by spark
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4758:
URL: https://github.com/apache/hudi/pull/4758#issuecomment-1031290831
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9e43f9f8b6c53222184b37a79faba04d7fa2e720",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5756",
"triggerID" : "9e43f9f8b6c53222184b37a79faba04d7fa2e720",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9e43f9f8b6c53222184b37a79faba04d7fa2e720 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5756)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4758: [HUDI-2610] pass the spark version when sync the table created by spark
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4758:
URL: https://github.com/apache/hudi/pull/4758#issuecomment-1033802773
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9e43f9f8b6c53222184b37a79faba04d7fa2e720",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5756",
"triggerID" : "9e43f9f8b6c53222184b37a79faba04d7fa2e720",
"triggerType" : "PUSH"
}, {
"hash" : "34313bf363083d33410d19fbe3145f852aff7447",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5840",
"triggerID" : "34313bf363083d33410d19fbe3145f852aff7447",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 34313bf363083d33410d19fbe3145f852aff7447 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5840)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4758: [HUDI-2610] pass the spark version when sync the table created by spark
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4758:
URL: https://github.com/apache/hudi/pull/4758#issuecomment-1031287617
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9e43f9f8b6c53222184b37a79faba04d7fa2e720",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9e43f9f8b6c53222184b37a79faba04d7fa2e720",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9e43f9f8b6c53222184b37a79faba04d7fa2e720 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codope commented on a change in pull request #4758: [HUDI-2610] pass the spark version when sync the table created by spark
Posted by GitBox <gi...@apache.org>.
codope commented on a change in pull request #4758:
URL: https://github.com/apache/hudi/pull/4758#discussion_r800537612
##########
File path: hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieSparkSqlWriter.scala
##########
@@ -573,6 +575,7 @@ object HoodieSparkSqlWriter {
hiveSyncConfig.syncMode = hoodieConfig.getString(HIVE_SYNC_MODE)
hiveSyncConfig.serdeProperties = hoodieConfig.getString(HIVE_TABLE_SERDE_PROPERTIES)
hiveSyncConfig.tableProperties = hoodieConfig.getString(HIVE_TABLE_PROPERTIES)
+ hiveSyncConfig.sparkVersion = SPARK_VERSION
Review comment:
How about also setting this for hive sync triggered through deltastreamer as well? `DeltaSync` uses `DataSourceUtils#buildHiveSyncConfig` to create hive sync configs.
##########
File path: hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/HiveSyncTool.java
##########
@@ -302,6 +303,9 @@ private boolean syncSchema(String tableName, boolean tableExists, boolean useRea
Map<String, String> sparkProperties = new HashMap<>();
sparkProperties.put("spark.sql.sources.provider", "hudi");
+ if (!StringUtils.isNullOrEmpty(cfg.sparkVersion)) {
+ sparkProperties.put("spark.sql.create.version", cfg.sparkVersion);
Review comment:
Is it just for visibility/debugging purpose, or does hive use this config in some way?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4758: [HUDI-2610] pass the spark version when sync the table created by spark
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4758:
URL: https://github.com/apache/hudi/pull/4758#issuecomment-1031290831
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9e43f9f8b6c53222184b37a79faba04d7fa2e720",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5756",
"triggerID" : "9e43f9f8b6c53222184b37a79faba04d7fa2e720",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9e43f9f8b6c53222184b37a79faba04d7fa2e720 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5756)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4758: [HUDI-2610] pass the spark version when sync the table created by spark
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4758:
URL: https://github.com/apache/hudi/pull/4758#issuecomment-1031370127
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9e43f9f8b6c53222184b37a79faba04d7fa2e720",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5756",
"triggerID" : "9e43f9f8b6c53222184b37a79faba04d7fa2e720",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9e43f9f8b6c53222184b37a79faba04d7fa2e720 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5756)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org