You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2019/11/19 00:41:25 UTC
[GitHub] [incubator-gobblin] enjoyear opened a new pull request #2818:
[GOBBLIN-963] Remove duplicated copies of TaskContext/TaskState when
constructing TaskIFaceWrapper
enjoyear opened a new pull request #2818: [GOBBLIN-963] Remove duplicated copies of TaskContext/TaskState when constructing TaskIFaceWrapper
URL: https://github.com/apache/incubator-gobblin/pull/2818
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
### JIRA
- [X] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-963] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-963
### Description
- [X] Here are some details about my PR, including screenshots (if applicable):
Currently in GobblinMultiTaskAttempt, when we call createTaskRunnable, we rely on a TaskFactory to create a task and return a wrapper for that task. However, when we create the wrapper, we initialized the TaskContext twice.
For the task creation
For the task wrapper creation
These two TaskContexts, which generate two copies of TaskState, will cause inconsistency in the following operation. The task state update within the task won't be reflected in TaskWrapper.
Specifically, this is the buggy line of code
```java
return new TaskIFaceWrapper(taskFactoryOpt.get().createTask(new TaskContext(workUnitState)),
new TaskContext(workUnitState), countDownLatch, this.taskStateTracker);
```
Ideally, we should create the TaskContext once, and reuse the same TaskContext.
### Tests
- [X] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
### Commits
- [X] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services