You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Mesos Reviewbot <re...@mesos.apache.org> on 2018/08/01 01:40:41 UTC
Re: Review Request 68094: Add port mapping and network ports isolators
sources to CMake.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68094/#review206715
-----------------------------------------------------------
Patch looks great!
Reviews applied: [67751, 68093, 68094]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On July 27, 2018, 12:11 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68094/
> -----------------------------------------------------------
>
> (Updated July 27, 2018, 12:11 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, James Peach, and Joseph Wu.
>
>
> Bugs: MESOS-8993 and MESOS-8994
> https://issues.apache.org/jira/browse/MESOS-8993
> https://issues.apache.org/jira/browse/MESOS-8994
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This adds the relevant options and source files, but with a fatal
> message if they're used, as we do not yet check for their
> dependencies. This also adds the `mesos-network-helper` executable as
> used by the port mapping isolator.
>
>
> Diffs
> -----
>
> cmake/CompilationConfigure.cmake f80c265d117c70acda95da6b943cdd3e4e477daa
> src/CMakeLists.txt 10b0946d6f49c7e9c201bad6f9f1b41cc8460fe5
> src/slave/containerizer/mesos/CMakeLists.txt ba1f92fe7dd59c34c6dee0bc7ecf6f1b5160eee8
> src/tests/CMakeLists.txt 695b6f543847d4270f7004a1768919904975d7a4
>
>
> Diff: https://reviews.apache.org/r/68094/diff/4/
>
>
> Testing
> -------
>
> Pending... There isn't much to test for the isolators added, as they're added with a fatal bailout. Double-checking that without enabling the new options, everything still works as expected.
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>