You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "aokolnychyi (via GitHub)" <gi...@apache.org> on 2023/07/28 20:49:39 UTC

[GitHub] [iceberg] aokolnychyi commented on a diff in pull request #8158: Core: use ZSTD compressed parquet by default

aokolnychyi commented on code in PR #8158:
URL: https://github.com/apache/iceberg/pull/8158#discussion_r1278072512


##########
core/src/main/java/org/apache/iceberg/TableProperties.java:
##########
@@ -142,12 +142,13 @@ private TableProperties() {}
 
   public static final String PARQUET_COMPRESSION = "write.parquet.compression-codec";
   public static final String DELETE_PARQUET_COMPRESSION = "write.delete.parquet.compression-codec";
-  public static final String PARQUET_COMPRESSION_DEFAULT = "gzip";
+  public static final String PARQUET_COMPRESSION_DEFAULT = "zstd";
 
   public static final String PARQUET_COMPRESSION_LEVEL = "write.parquet.compression-level";
   public static final String DELETE_PARQUET_COMPRESSION_LEVEL =
       "write.delete.parquet.compression-level";
-  public static final String PARQUET_COMPRESSION_LEVEL_DEFAULT = null;
+  public static final String PARQUET_COMPRESSION_LEVEL_DEFAULT =
+      null; // For zstd, it is default to "3"

Review Comment:
   How valuable is this comment given than it is specific to the underlying codec and may change in the future?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org