You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2022/04/21 22:36:50 UTC
[GitHub] [druid] ApoorvGuptaAi opened a new pull request, #12470: Fix formatting in stats.md
ApoorvGuptaAi opened a new pull request, #12470:
URL: https://github.com/apache/druid/pull/12470
### Description
Fix formatting in stats.md: Add newlines to fix the formatting for a list.
<hr>
This PR has:
- [x ] been self-reviewed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] FrankChen021 commented on a diff in pull request #12470: Fix formatting in stats.md
Posted by GitBox <gi...@apache.org>.
FrankChen021 commented on code in PR #12470:
URL: https://github.com/apache/druid/pull/12470#discussion_r855791318
##########
docs/development/extensions-core/stats.md:
##########
@@ -35,10 +35,13 @@ The American Statistician, 37 (1983) pp. 242--247.
variance = variance1 + variance2 + n/(m*(m+n)) * pow(((m/n)*t1 - t2),2)
-where: - variance is sum(x-avg^2) (this is actually n times the variance)
-and is updated at every step. - n is the count of elements in chunk1 - m is
-the count of elements in chunk2 - t1 = sum of elements in chunk1, t2 =
-sum of elements in chunk2.
+where:
+ - variance is sum(x-avg^2) (this is actually n times the variance)
+and is updated at every step.
+ - n is the count of elements in chunk1
+ - m is the count of elements in chunk2
+ - t1 = sum of elements in chunk1
Review Comment:
```suggestion
- t1 is the sum of elements in chunk1
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] FrankChen021 merged pull request #12470: Fix formatting in stats.md
Posted by GitBox <gi...@apache.org>.
FrankChen021 merged PR #12470:
URL: https://github.com/apache/druid/pull/12470
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] FrankChen021 commented on pull request #12470: Fix formatting in stats.md
Posted by GitBox <gi...@apache.org>.
FrankChen021 commented on PR #12470:
URL: https://github.com/apache/druid/pull/12470#issuecomment-1105939815
Thank you @ApoorvGuptaAi for your first contribution on Druid. Left a minor change for you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] FrankChen021 commented on pull request #12470: Fix formatting in stats.md
Posted by GitBox <gi...@apache.org>.
FrankChen021 commented on PR #12470:
URL: https://github.com/apache/druid/pull/12470#issuecomment-1106647303
Thank you @ApoorvGuptaAi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] FrankChen021 commented on a diff in pull request #12470: Fix formatting in stats.md
Posted by GitBox <gi...@apache.org>.
FrankChen021 commented on code in PR #12470:
URL: https://github.com/apache/druid/pull/12470#discussion_r855791243
##########
docs/development/extensions-core/stats.md:
##########
@@ -35,10 +35,13 @@ The American Statistician, 37 (1983) pp. 242--247.
variance = variance1 + variance2 + n/(m*(m+n)) * pow(((m/n)*t1 - t2),2)
-where: - variance is sum(x-avg^2) (this is actually n times the variance)
-and is updated at every step. - n is the count of elements in chunk1 - m is
-the count of elements in chunk2 - t1 = sum of elements in chunk1, t2 =
-sum of elements in chunk2.
+where:
+ - variance is sum(x-avg^2) (this is actually n times the variance)
+and is updated at every step.
+ - n is the count of elements in chunk1
+ - m is the count of elements in chunk2
+ - t1 = sum of elements in chunk1
+ - t2 = sum of elements in chunk2.
Review Comment:
```suggestion
- t2 is the sum of elements in chunk2
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] FrankChen021 commented on a diff in pull request #12470: Fix formatting in stats.md
Posted by GitBox <gi...@apache.org>.
FrankChen021 commented on code in PR #12470:
URL: https://github.com/apache/druid/pull/12470#discussion_r855718896
##########
docs/development/extensions-core/stats.md:
##########
@@ -35,9 +35,12 @@ The American Statistician, 37 (1983) pp. 242--247.
variance = variance1 + variance2 + n/(m*(m+n)) * pow(((m/n)*t1 - t2),2)
-where: - variance is sum(x-avg^2) (this is actually n times the variance)
-and is updated at every step. - n is the count of elements in chunk1 - m is
-the count of elements in chunk2 - t1 = sum of elements in chunk1, t2 =
+where:
+ - variance is sum(x-avg^2) (this is actually n times the variance)
+and is updated at every step.
+ - n is the count of elements in chunk1
+ - m is the count of elements in chunk2
+ - t1 = sum of elements in chunk1, t2 =
Review Comment:
Since all parameters are formatted as list item above, I think It's better to put `t2` in a separate list item too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org