You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2017/07/11 00:17:55 UTC
Re: Review Request 60338: Windows: Made `dynamiclibrary.hpp` use
Unicode.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60338/#review180126
-----------------------------------------------------------
Ship it!
3rdparty/stout/include/stout/windows/dynamiclibrary.hpp
Line 88 (original), 89-90 (patched)
<https://reviews.apache.org/r/60338/#comment255151>
I don't think this comment is necessary since we're not talking about a path here :)
(UTF-16 C symbols would be weird...)
- Joseph Wu
On June 21, 2017, 3:16 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60338/
> -----------------------------------------------------------
>
> (Updated June 21, 2017, 3:16 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Jeff Coffler, John Kordich, Joseph Wu, Li Li, and Michael Park.
>
>
> Bugs: MESOS-6817
> https://issues.apache.org/jira/browse/MESOS-6817
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Windows: Made `dynamiclibrary.hpp` use Unicode.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/windows/dynamiclibrary.hpp 28b8e32ecc6748449d2623637e58bab25b2a6590
>
>
> Diff: https://reviews.apache.org/r/60338/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>