[GitHub] [iceberg-rust] liurenjie1024 commented on pull request #62: feat: add builder to TableMetadata interface

["liurenjie1024 (via GitHub)" <gi...@apache.org>]

liurenjie1024 commented on PR #62:
URL: https://github.com/apache/iceberg-rust/pull/62#issuecomment-1732834551

   +1 with @zeodtr We should have a validation check in the final phase of build, so an auto generated builder maybe inappropricate. How about this:
   ```
   struct TableMetadataBuilder(TableMetadata);
   
   impl TableMetadataBuilder {
       ...
       pub fn build(self) {
          // validate 
         self.0
       }
   }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org