You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "DongLiang-0 (via GitHub)" <gi...@apache.org> on 2023/11/24 06:07:06 UTC

[PR] [fix]Fix the first schema change does not take effect when the source… [doris-flink-connector]

DongLiang-0 opened a new pull request, #243:
URL: https://github.com/apache/doris-flink-connector/pull/243

   … table has no data.
   
   # Proposed changes
   close: https://github.com/apache/doris-flink-connector/issues/238
   
   ## Problem Summary:
   
   Describe the overview of changes.
   
   ## Checklist(Required)
   
   1. Does it affect the original behavior: (Yes/No/I Don't know)
   2. Has unit tests been added: (Yes/No/No Need)
   3. Has document been added or modified: (Yes/No/No Need)
   4. Does it need to update dependencies: (Yes/No)
   5. Are there any changes that cannot be rolled back: (Yes/No)
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix]Fix the first schema change does not take effect when the source… [doris-flink-connector]

Posted by "DongLiang-0 (via GitHub)" <gi...@apache.org>.
DongLiang-0 closed pull request #243: [fix]Fix the first schema change does not take effect when the source…
URL: https://github.com/apache/doris-flink-connector/pull/243


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix]Fix the first schema change does not take effect when the source… [doris-flink-connector]

Posted by "JNSimba (via GitHub)" <gi...@apache.org>.
JNSimba commented on code in PR #243:
URL: https://github.com/apache/doris-flink-connector/pull/243#discussion_r1404100841


##########
flink-doris-connector/src/main/java/org/apache/doris/flink/sink/writer/serializer/JsonDebeziumSchemaSerializer.java:
##########
@@ -105,6 +109,7 @@ public JsonDebeziumSchemaSerializer(DorisOptions dorisOptions,
         this.firstLoad = true;
         this.firstSchemaChange = true;
         this.schemaChangeManager = new SchemaChangeManager(dorisOptions);
+        this.dorisSystem = new DorisSystem(dorisOptions);

Review Comment:
   DorisSystem needs to pass in jdbc-url, which was not required in previous versions. Can it be made compatible?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org