You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@plc4x.apache.org by sr...@apache.org on 2021/10/27 12:26:33 UTC

[plc4x-build-tools] branch feature/mspec-ng updated: fix(plc4j/codgen): avoid duplicating params

This is an automated email from the ASF dual-hosted git repository.

sruehl pushed a commit to branch feature/mspec-ng
in repository https://gitbox.apache.org/repos/asf/plc4x-build-tools.git


The following commit(s) were added to refs/heads/feature/mspec-ng by this push:
     new 7b0da44  fix(plc4j/codgen): avoid duplicating params
7b0da44 is described below

commit 7b0da448a8242a9893dbd7311b55329b2672caf8
Author: Sebastian Rühl <sr...@apache.org>
AuthorDate: Wed Oct 27 14:26:23 2021 +0200

    fix(plc4j/codgen): avoid duplicating params
---
 .../codegenerator/types/references/DefaultComplexTypeReference.java    | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/code-generation/types-base/src/main/java/org/apache/plc4x/plugins/codegenerator/types/references/DefaultComplexTypeReference.java b/code-generation/types-base/src/main/java/org/apache/plc4x/plugins/codegenerator/types/references/DefaultComplexTypeReference.java
index 51ab479..9a2744d 100644
--- a/code-generation/types-base/src/main/java/org/apache/plc4x/plugins/codegenerator/types/references/DefaultComplexTypeReference.java
+++ b/code-generation/types-base/src/main/java/org/apache/plc4x/plugins/codegenerator/types/references/DefaultComplexTypeReference.java
@@ -31,8 +31,7 @@ public class DefaultComplexTypeReference implements ComplexTypeReference {
     private final List<Term> params;
 
     public DefaultComplexTypeReference(String name, List<Term> params) {
-        // TODO: add null checks
-        this.name = name;
+        this.name = Objects.requireNonNull(name);
         this.params = params;
     }