[jira] [Commented] (UIMA-2435) External Settings files are not closed

["Marshall Schor (JIRA)" <de...@uima.apache.org>]

    [ https://issues.apache.org/jira/browse/UIMA-2435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13413955#comment-13413955 ] 

Marshall Schor commented on UIMA-2435:
--------------------------------------

Not sure about the load method doing the closing... I think the general convention is to have the component that "opened" a stream be the one to close it.  It might surprise a developer in the future who opens a stream, calls load (passing the open stream), and then closes the stream, to get some error like "stream already closed".  (I haven't researched this, though, so it may be not a real issue).  I think it's a good idea to design systems to behave with "minimal surprise" :-)...
                
> External Settings files are not closed 
> ---------------------------------------
>
>                 Key: UIMA-2435
>                 URL: https://issues.apache.org/jira/browse/UIMA-2435
>             Project: UIMA
>          Issue Type: Bug
>          Components: Core Java Framework
>            Reporter: Burn Lewis
>            Priority: Minor
>             Fix For: 2.4.1SDK
>
>
> After settings files are loaded they should be closed ... callers often forget ... should be safe to do it in the load method.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira