You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Andrew Zhang (JIRA)" <ji...@apache.org> on 2006/07/19 07:17:15 UTC
[jira] Created: (HARMONY-914) [classlib][nio] refine
o.a.h.nio.SocketChannelImpl
[classlib][nio] refine o.a.h.nio.SocketChannelImpl
--------------------------------------------------
Key: HARMONY-914
URL: http://issues.apache.org/jira/browse/HARMONY-914
Project: Harmony
Issue Type: Improvement
Components: Classlib
Reporter: Andrew Zhang
Hello,
SocketChannelImpl.connect(SocketAddress socketAddress) checks whether
socketAddress.getPort() is illegal. This is unnecessary as we can not create a SocketAddress
with an illegal port number.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (HARMONY-914) [classlib][nio] refine
o.a.h.nio.SocketChannelImpl
Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-914?page=all ]
Paulex Yang closed HARMONY-914.
-------------------------------
Estimated Complexity: Novice
Verified by Andrew.
> [classlib][nio] refine o.a.h.nio.SocketChannelImpl
> --------------------------------------------------
>
> Key: HARMONY-914
> URL: http://issues.apache.org/jira/browse/HARMONY-914
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Reporter: Andrew Zhang
> Assigned To: Paulex Yang
> Attachments: SocketChannelImpl.diff
>
>
> Hello,
> SocketChannelImpl.connect(SocketAddress socketAddress) checks whether
> socketAddress.getPort() is illegal. This is unnecessary as we can not create a SocketAddress
> with an illegal port number.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-914) [classlib][nio] refine
o.a.h.nio.SocketChannelImpl
Posted by "Andrew Zhang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-914?page=all ]
Andrew Zhang updated HARMONY-914:
---------------------------------
Attachment: SocketChannelImpl.diff
Hello,
Would you please try my patch?
Thanks!
Best regards,
Andrew
> [classlib][nio] refine o.a.h.nio.SocketChannelImpl
> --------------------------------------------------
>
> Key: HARMONY-914
> URL: http://issues.apache.org/jira/browse/HARMONY-914
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Reporter: Andrew Zhang
> Attachments: SocketChannelImpl.diff
>
>
> Hello,
> SocketChannelImpl.connect(SocketAddress socketAddress) checks whether
> socketAddress.getPort() is illegal. This is unnecessary as we can not create a SocketAddress
> with an illegal port number.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (HARMONY-914) [classlib][nio] refine
o.a.h.nio.SocketChannelImpl
Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-914?page=all ]
Paulex Yang reassigned HARMONY-914:
-----------------------------------
Assignee: Paulex Yang
> [classlib][nio] refine o.a.h.nio.SocketChannelImpl
> --------------------------------------------------
>
> Key: HARMONY-914
> URL: http://issues.apache.org/jira/browse/HARMONY-914
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Reporter: Andrew Zhang
> Assigned To: Paulex Yang
> Attachments: SocketChannelImpl.diff
>
>
> Hello,
> SocketChannelImpl.connect(SocketAddress socketAddress) checks whether
> socketAddress.getPort() is illegal. This is unnecessary as we can not create a SocketAddress
> with an illegal port number.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-914) [classlib][nio] refine
o.a.h.nio.SocketChannelImpl
Posted by "Andrew Zhang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-914?page=comments#action_12422315 ]
Andrew Zhang commented on HARMONY-914:
--------------------------------------
Hello Paulex,
The fix is good. And thanks for comments!
Best regards,
Andrew
> [classlib][nio] refine o.a.h.nio.SocketChannelImpl
> --------------------------------------------------
>
> Key: HARMONY-914
> URL: http://issues.apache.org/jira/browse/HARMONY-914
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Reporter: Andrew Zhang
> Assigned To: Paulex Yang
> Attachments: SocketChannelImpl.diff
>
>
> Hello,
> SocketChannelImpl.connect(SocketAddress socketAddress) checks whether
> socketAddress.getPort() is illegal. This is unnecessary as we can not create a SocketAddress
> with an illegal port number.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (HARMONY-914) [classlib][nio] refine
o.a.h.nio.SocketChannelImpl
Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-914?page=all ]
Paulex Yang resolved HARMONY-914.
---------------------------------
Resolution: Fixed
Patch applied at revision r423423, thanks a lot for this enhancement, please verify that the problem is fully fixed as you expected.
However, I have some comments on this issue, the SocketAddress is not guaranteed to has valid port, because it is public abstract class and can be extended. But the patch is still valid, because SocketChannel.connect() only actually accepts InetSocketAddress, otherwise it will throw UnsupportedAddressTypeException, further the InetSocketAddress has no way to have a invalid port.
> [classlib][nio] refine o.a.h.nio.SocketChannelImpl
> --------------------------------------------------
>
> Key: HARMONY-914
> URL: http://issues.apache.org/jira/browse/HARMONY-914
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Reporter: Andrew Zhang
> Assigned To: Paulex Yang
> Attachments: SocketChannelImpl.diff
>
>
> Hello,
> SocketChannelImpl.connect(SocketAddress socketAddress) checks whether
> socketAddress.getPort() is illegal. This is unnecessary as we can not create a SocketAddress
> with an illegal port number.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira