You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@unomi.apache.org by GitBox <gi...@apache.org> on 2020/06/10 11:05:10 UTC
[GitHub] [unomi] sergehuber commented on a change in pull request #165: UNOMI-347 improve query results
sergehuber commented on a change in pull request #165:
URL: https://github.com/apache/unomi/pull/165#discussion_r438032422
##########
File path: graphql/cxs-impl/src/main/java/org/apache/unomi/graphql/fetchers/BaseConnectionDataFetcher.java
##########
@@ -34,6 +34,7 @@ protected ConnectionParams parseConnectionParams(final DataFetchingEnvironment e
.last(parseParam("last", null, environment))
.after(parseParam("after", null, environment))
.before(parseParam("before", null, environment))
+ .text(parseParam("text", null, environment))
Review comment:
We should rename this unomi_text
##########
File path: graphql/cxs-impl/src/main/java/org/apache/unomi/graphql/types/output/CDPPageInfo.java
##########
@@ -54,4 +58,8 @@ public CDPPageInfo setHasNextPage(boolean hasNextPage) {
this.hasNextPage = hasNextPage;
return this;
}
+
+ public Long getTotalSize() {
Review comment:
This needs a @GraphQLField("unomi_totalSize") annotation since it is an extension not part of the specification.
##########
File path: graphql/cxs-impl/src/main/java/org/apache/unomi/graphql/types/output/CDPQuery.java
##########
@@ -88,6 +89,7 @@ public CDPEventConnection findEvents(final @GraphQLName("filter") CDPEventFilter
final @GraphQLName("after") String after,
final @GraphQLName("last") Integer last,
final @GraphQLName("before") String before,
+ final @GraphQLName("text") String text,
Review comment:
Same as before :)
##########
File path: graphql/cxs-impl/src/main/java/org/apache/unomi/graphql/types/output/CDPQuery.java
##########
@@ -68,6 +68,7 @@ public CDPProfileConnection findProfiles(final @GraphQLName("filter") CDPProfile
final @GraphQLName("after") String after,
final @GraphQLName("last") Integer last,
final @GraphQLName("before") String before,
+ final @GraphQLName("text") String text,
Review comment:
Same comment as before, rename to unomi_text and we should also add a description to explain what it is for.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org