You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/08/09 10:33:24 UTC

[GitHub] [incubator-nuttx] davids5 commented on a diff in pull request #6815: pic32mx: add option to disable JTAG at runtime

davids5 commented on code in PR #6815:
URL: https://github.com/apache/incubator-nuttx/pull/6815#discussion_r941174731


##########
arch/mips/src/pic32mx/pic32mx_lowinit.c:
##########
@@ -192,6 +247,12 @@ void pic32mx_lowinit(void)
   up_earlyserialinit();
 #endif
 
+#if CONFIG_PIC32MX_JTAG_ENABLE

Review Comment:
   What is the HW default? 
   Why not do this as compile time option?.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org