You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2018/06/08 11:50:45 UTC

[GitHub] akrabat opened a new pull request #3736: Add support for PHP 7.2 runtime

akrabat opened a new pull request #3736: Add support for PHP 7.2 runtime
URL: https://github.com/apache/incubator-openwhisk/pull/3736
 
 
   ## Description
   This PR adds PHP 7.2 as a new kind and sets the default PHP runtime to version 7.2.
   
   I have not provided runtime tests here as they are in the runtime-php repository and they are being removed anyway via https://github.com/apache/incubator-openwhisk/pull/3467. I'm not sure which additional tests are needed in this repo.
   
   ## Related issue and scope
   
   https://github.com/apache/incubator-openwhisk-runtime-php/pull/28 needs to be merged and the relevant Docker containers built and uploaded to the Docker Hub first.
   
   ## My changes affect the following components
   - [ ] API
   - [ ] Controller
   - [ ] Message Bus (e.g., Kafka)
   - [ ] Loadbalancer
   - [ ] Invoker
   - [x] Intrinsic actions (e.g., sequences, conductors)
   - [ ] Data stores (e.g., CouchDB)
   - [ ] Tests
   - [ ] Deployment
   - [ ] CLI
   - [ ] General tooling
   - [x] Documentation
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Use `x` in all the boxes that apply: -->
   - [ ] Bug fix (generally a non-breaking change which closes an issue).
   - [x] Enhancement or new feature (adds new functionality).
   - [ ] Breaking change (a bug fix or enhancement which changes existing behavior).
   
   ## Checklist:
   <!--- Please review the points below which help you make sure you've covered all aspects of the change you're making. -->
   
   - [x] I signed an [Apache CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md).
   - [x] I reviewed the [style guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :).
   - [ ] I added tests to cover my changes.
   - [ ] My changes require further changes to the documentation.
   - [x] I updated the documentation where necessary.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services