You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by gu...@apache.org on 2018/01/22 00:45:32 UTC
spark git commit: [SPARK-23169][INFRA][R] Run lintr on the changes of
lint-r script and .lintr configuration
Repository: spark
Updated Branches:
refs/heads/master 2239d7a41 -> 12faae295
[SPARK-23169][INFRA][R] Run lintr on the changes of lint-r script and .lintr configuration
## What changes were proposed in this pull request?
When running the `run-tests` script, seems we don't run lintr on the changes of `lint-r` script and `.lintr` configuration.
## How was this patch tested?
Jenkins builds
Author: hyukjinkwon <gu...@gmail.com>
Closes #20339 from HyukjinKwon/check-r-changed.
Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/12faae29
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/12faae29
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/12faae29
Branch: refs/heads/master
Commit: 12faae295e42820b99a695ba49826051944244e1
Parents: 2239d7a
Author: hyukjinkwon <gu...@gmail.com>
Authored: Mon Jan 22 09:45:27 2018 +0900
Committer: hyukjinkwon <gu...@gmail.com>
Committed: Mon Jan 22 09:45:27 2018 +0900
----------------------------------------------------------------------
dev/run-tests.py | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/spark/blob/12faae29/dev/run-tests.py
----------------------------------------------------------------------
diff --git a/dev/run-tests.py b/dev/run-tests.py
index 7e6f7ff..fb270c4 100755
--- a/dev/run-tests.py
+++ b/dev/run-tests.py
@@ -578,7 +578,10 @@ def main():
pass
if not changed_files or any(f.endswith(".py") for f in changed_files):
run_python_style_checks()
- if not changed_files or any(f.endswith(".R") for f in changed_files):
+ if not changed_files or any(f.endswith(".R")
+ or f.endswith("lint-r")
+ or f.endswith(".lintr")
+ for f in changed_files):
run_sparkr_style_checks()
# determine if docs were changed and if we're inside the amplab environment
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org