You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/05 12:15:15 UTC
[GitHub] [spark] cloud-fan commented on a change in pull request #27643:
[SPARK-30886][SQL] Deprecate LTRIM, RTRIM, and two-parameter TRIM functions
cloud-fan commented on a change in pull request #27643: [SPARK-30886][SQL] Deprecate LTRIM, RTRIM, and two-parameter TRIM functions
URL: https://github.com/apache/spark/pull/27643#discussion_r388256465
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##########
@@ -1839,13 +1842,25 @@ class Analyzer(
}
AggregateExpression(agg, Complete, isDistinct, filter)
// This function is not an aggregate function, just return the resolved one.
- case other =>
- if (isDistinct || filter.isDefined) {
- failAnalysis("DISTINCT or FILTER specified, " +
- s"but ${other.prettyName} is not an aggregate function")
- } else {
- other
+ case other if (isDistinct || filter.isDefined) =>
+ failAnalysis("DISTINCT or FILTER specified, " +
+ s"but ${other.prettyName} is not an aggregate function")
+ case e @ (_: StringTrimLeft | _: StringTrimRight) =>
Review comment:
Seems like one-parameter `ltrim` and `rtrim` have well defined semantic and are consistent with other databases. I'm OK to keep them, although users can do the same thing with the TRIM syntax.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org