You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/03 08:17:17 UTC
[GitHub] [arrow-datafusion] WinkerDu opened a new pull request, #2425: minor: format table result vec & remove some unnecessary semicolons
WinkerDu opened a new pull request, #2425:
URL: https://github.com/apache/arrow-datafusion/pull/2425
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
As a follow up pr of #2413 , and remove some unnecessary semicolons like
```
...
if states.is_empty() {
return Ok(());
}; // we can remove this semicolon for code clean
...
```
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
No.
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
No.
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Dandandan commented on pull request #2425: minor: format table result vec & remove some unnecessary semicolons
Posted by GitBox <gi...@apache.org>.
Dandandan commented on PR #2425:
URL: https://github.com/apache/arrow-datafusion/pull/2425#issuecomment-1116016726
> I'm curious why rustfmt isn't finding the semicolons...
In Rust `;` is not meaningless, a block that returns a value no longer has a value after adding `;`.
I think `rustfmt` only knows rust syntax, so this would be more something for rustc/clippy I think. Not sure why the existing lints don´t catch it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Dandandan merged pull request #2425: minor: format table result vec & remove some unnecessary semicolons
Posted by GitBox <gi...@apache.org>.
Dandandan merged PR #2425:
URL: https://github.com/apache/arrow-datafusion/pull/2425
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org