You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/11/19 17:56:48 UTC
[GitHub] [ozone-docker] adoroszlai opened a new pull request #22: HDDS-6015. Publish docker image for Ozone 1.2.0
adoroszlai opened a new pull request #22:
URL: https://github.com/apache/ozone-docker/pull/22
## What changes were proposed in this pull request?
Update dockerfile etc. for building with recently released version 1.2.0.
https://issues.apache.org/jira/browse/HDDS-6015
## How was this patch tested?
Built locally:
```
$ ./build.sh
...
=> => writing image sha256:8b2eadd31396a9788b94dc346e92d9393c79ab9cafb97f32fdefd96ceac5aeab
=> => naming to docker.io/apache/ozone
```
Tested:
```
$ docker-compose up -d --scale datanode=3
$ docker-compose exec om ozone version
...
/ 1.2.0(Glacier)
Source code repository https://github.com/apache/ozone.git -r 9ee6f1872dca8469057d3c7bf880931c0e7b7f3e
Compiled by ethanrose on 2021-11-10T16:28Z
...
$ open http://localhost:9874
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone-docker] adoroszlai commented on a change in pull request #22: HDDS-6015. Publish docker image for Ozone 1.2.0
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on a change in pull request #22:
URL: https://github.com/apache/ozone-docker/pull/22#discussion_r753447438
##########
File path: Dockerfile
##########
@@ -13,10 +13,10 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-FROM apache/ozone-runner:20191107-1
-ARG OZONE_URL=https://www.apache.org/dyn/mirrors/mirrors.cgi?action=download&filename=hadoop/ozone/ozone-1.0.0/hadoop-ozone-1.0.0.tar.gz
+FROM apache/ozone-runner:20210520-1
+ARG OZONE_URL=https://dlcdn.apache.org/ozone/1.2.0/ozone-1.2.0.tar.gz
WORKDIR /opt
-RUN sudo rm -rf /opt/hadoop && wget $OZONE_URL -O ozone.tar.gz && tar zxf ozone.tar.gz && rm ozone.tar.gz && mv ozone* hadoop
+RUN sudo rm -rf /opt/hadoop && curl -LSs -o ozone.tar.gz $OZONE_URL && tar zxf ozone.tar.gz && rm ozone.tar.gz && mv ozone* hadoop
WORKDIR /opt/hadoop
Review comment:
I guess that would cause disruption because `/opt/hadoop` appears everywhere in smoketests and compose files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone-docker] adoroszlai commented on pull request #22: HDDS-6015. Publish docker image for Ozone 1.2.0
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #22:
URL: https://github.com/apache/ozone-docker/pull/22#issuecomment-981873748
@errose28 As far as I know `ozone-X` branches trigger image creation in Docker Hub with tag `X`, while `latest` does not. I'm not sure why we need both `latest` and `ozone-latest`. One reason might be to avoid triggering rebuild of `latest` image for changes that do not affect the image. For example most recently the addition of a `NOTICE` file, which is not copied into the image, hence does not change it.
We should probably merge `ozone-latest` into `latest` to update with the 1.1.0 changes. After that, the changes for 1.2.0 (this PR) can be targeted at either of the two branches. Since `latest` is the default branch, I think we might want to prefer that as target.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone-docker] errose28 commented on pull request #22: HDDS-6015. Publish docker image for Ozone 1.2.0
Posted by GitBox <gi...@apache.org>.
errose28 commented on pull request #22:
URL: https://github.com/apache/ozone-docker/pull/22#issuecomment-982061201
> As far as I know ozone-X branches trigger image creation in Docker Hub with tag X, while latest does not.
This makes sense, thanks for the explanation.
> We should probably merge ozone-latest into latest to update with the 1.1.0 changes. After that, the changes for 1.2.0 (this PR) can be targeted at either of the two branches. Since latest is the default branch, I think we might want to prefer that as target.
We want `ozone-latest` and `ozone-1.2.0` pointing at the same commit after this PR, right? So I think doing what you mentioned will work, and after merging this PR fast-forward `ozone-latest` to `latest` and create `ozone-1.2.0` off `latest`.
So now it looks like the intended flow is to merge all changes to `latest`, and fast-forward `ozone-latest` when we want to do a docker hub release. However, since 1.1.0 went in to `ozone-latest` (probably by mistake), it won't be a fast-forward this time but a regular merge like you mentioned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone-docker] adoroszlai commented on pull request #22: HDDS-6015. Publish docker image for Ozone 1.2.0
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #22:
URL: https://github.com/apache/ozone-docker/pull/22#issuecomment-984471506
Thanks @errose28 for the reviews.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone-docker] adoroszlai commented on pull request #22: HDDS-6015. Publish docker image for Ozone 1.2.0
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #22:
URL: https://github.com/apache/ozone-docker/pull/22#issuecomment-982858812
Thanks @errose28 for the review. I have updated `latest` and rebased this PR on top of that. Can you please take another look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone-docker] errose28 commented on a change in pull request #22: HDDS-6015. Publish docker image for Ozone 1.2.0
Posted by GitBox <gi...@apache.org>.
errose28 commented on a change in pull request #22:
URL: https://github.com/apache/ozone-docker/pull/22#discussion_r753496351
##########
File path: Dockerfile
##########
@@ -13,10 +13,10 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-FROM apache/ozone-runner:20191107-1
-ARG OZONE_URL=https://www.apache.org/dyn/mirrors/mirrors.cgi?action=download&filename=hadoop/ozone/ozone-1.0.0/hadoop-ozone-1.0.0.tar.gz
+FROM apache/ozone-runner:20210520-1
+ARG OZONE_URL=https://dlcdn.apache.org/ozone/1.2.0/ozone-1.2.0.tar.gz
WORKDIR /opt
-RUN sudo rm -rf /opt/hadoop && wget $OZONE_URL -O ozone.tar.gz && tar zxf ozone.tar.gz && rm ozone.tar.gz && mv ozone* hadoop
+RUN sudo rm -rf /opt/hadoop && curl -LSs -o ozone.tar.gz $OZONE_URL && tar zxf ozone.tar.gz && rm ozone.tar.gz && mv ozone* hadoop
WORKDIR /opt/hadoop
Review comment:
Ok makes sense lets leave it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone-docker] errose28 commented on a change in pull request #22: HDDS-6015. Publish docker image for Ozone 1.2.0
Posted by GitBox <gi...@apache.org>.
errose28 commented on a change in pull request #22:
URL: https://github.com/apache/ozone-docker/pull/22#discussion_r753422111
##########
File path: Dockerfile
##########
@@ -13,10 +13,10 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-FROM apache/ozone-runner:20191107-1
-ARG OZONE_URL=https://www.apache.org/dyn/mirrors/mirrors.cgi?action=download&filename=hadoop/ozone/ozone-1.0.0/hadoop-ozone-1.0.0.tar.gz
+FROM apache/ozone-runner:20210520-1
+ARG OZONE_URL=https://dlcdn.apache.org/ozone/1.2.0/ozone-1.2.0.tar.gz
WORKDIR /opt
-RUN sudo rm -rf /opt/hadoop && wget $OZONE_URL -O ozone.tar.gz && tar zxf ozone.tar.gz && rm ozone.tar.gz && mv ozone* hadoop
+RUN sudo rm -rf /opt/hadoop && curl -LSs -o ozone.tar.gz $OZONE_URL && tar zxf ozone.tar.gz && rm ozone.tar.gz && mv ozone* hadoop
WORKDIR /opt/hadoop
Review comment:
Should we use /opt/ozone since we are no longer part of hadoop, or do we need to use /opt/hadoop for some compatibility purposes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone-docker] adoroszlai merged pull request #22: HDDS-6015. Publish docker image for Ozone 1.2.0
Posted by GitBox <gi...@apache.org>.
adoroszlai merged pull request #22:
URL: https://github.com/apache/ozone-docker/pull/22
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org