You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/05/18 17:42:00 UTC
[GitHub] [druid] loquisgon opened a new pull request #11271: Add an issues section to deal with common issues when building druid
loquisgon opened a new pull request #11271:
URL: https://github.com/apache/druid/pull/11271
Add a section to the build from source page to explain common build issues
This PR has:
- [X ] been self-reviewed.
- [ ] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.)
- [ X] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] suneet-s merged pull request #11271: Add an issues section to deal with common issues when building druid
Posted by GitBox <gi...@apache.org>.
suneet-s merged pull request #11271:
URL: https://github.com/apache/druid/pull/11271
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] asdf2014 commented on a change in pull request #11271: Add an issues section to deal with common issues when building druid
Posted by GitBox <gi...@apache.org>.
asdf2014 commented on a change in pull request #11271:
URL: https://github.com/apache/druid/pull/11271#discussion_r636587095
##########
File path: docs/development/build.md
##########
@@ -69,3 +69,15 @@ Putting these together, if you wish to build the source and binary distributions
```bash
mvn clean install -Papache-release,dist,rat -DskipTests
```
+#### Potential issues
Review comment:
nit: please leave a blank line here
```suggestion
#### Potential issues
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org