[jira] [Commented] (BEAM-230) Remove WindowedValue#valueInEmptyWindows

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16200970#comment-16200970 ] 

ASF GitHub Bot commented on BEAM-230:
-------------------------------------

GitHub user kennknowles opened a pull request:

    https://github.com/apache/beam/pull/3978

    [BEAM-230] Remove deprecated WindowedValue.valueInEmptyWindows

    Follow this checklist to help us incorporate your contribution quickly and easily:
    
     - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
     - [ ] Each commit in the pull request should have a meaningful subject line and body.
     - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue.
     - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
     - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
     - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---
    
    I noticed this branch sitting around and tests seem to pass for me. I think things are probably quite different than when PR #1440 didn't get in.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/beam valueInEmptyWindows

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/3978.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3978
    
----
commit 92e60f989839b234d444056e53ee36aeeea64fe8
Author: Kenneth Knowles <kl...@google.com>
Date:   2017-04-21T22:12:14Z

    Remove deprecated WindowedValue.valueInEmptyWindows

----


> Remove WindowedValue#valueInEmptyWindows
> ----------------------------------------
>
>                 Key: BEAM-230
>                 URL: https://issues.apache.org/jira/browse/BEAM-230
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-core
>            Reporter: Thomas Groh
>            Assignee: Kenneth Knowles
>             Fix For: Not applicable
>
>
> A WindowedValue in no windows does not exist, and can be dropped by a runner at any time.
> We should also assert that any collection of windows is nonempty when creating a new WindowedValue. If a user wants to drop an element, they should explicitly filter it out rather than expecting it to be dropped by the runner.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)