You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@plc4x.apache.org by GitBox <gi...@apache.org> on 2020/08/28 10:07:39 UTC
[GitHub] [plc4x] splatch opened a new pull request #182: PLC4X-244 Support for variable length padding fields.
splatch opened a new pull request #182:
URL: https://github.com/apache/plc4x/pull/182
Padding expression must now evaluate to an integer specifying how many times 'padding' field needs to be read or written to the buffer.
S7 parser tests are fine with this change as well as my experiments with socketcan payloads.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [plc4x] chrisdutz commented on pull request #182: PLC4X-244 Support for variable length padding fields.
Posted by GitBox <gi...@apache.org>.
chrisdutz commented on pull request #182:
URL: https://github.com/apache/plc4x/pull/182#issuecomment-684905262
Just saw that due to the nature of C ... you found all the places that needed adjusting ... thank you very much :-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [plc4x] splatch commented on pull request #182: PLC4X-244 Support for variable length padding fields.
Posted by GitBox <gi...@apache.org>.
splatch commented on pull request #182:
URL: https://github.com/apache/plc4x/pull/182#issuecomment-684965544
Good spot on naming, I did a blind change trying to keep it close to initial names. Anyhow, thanks for taking care of this!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [plc4x] chrisdutz commented on pull request #182: PLC4X-244 Support for variable length padding fields.
Posted by GitBox <gi...@apache.org>.
chrisdutz commented on pull request #182:
URL: https://github.com/apache/plc4x/pull/182#issuecomment-684899684
I will probably need to add something to the size-calculation in C too, but I'll take care of this. Perhaps also change the name of the varialbe from "needsPadding" to "numPading" or similar ... "needs" sounds binary to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [plc4x] chrisdutz merged pull request #182: PLC4X-244 Support for variable length padding fields.
Posted by GitBox <gi...@apache.org>.
chrisdutz merged pull request #182:
URL: https://github.com/apache/plc4x/pull/182
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org