[GitHub] [kyuubi] risyomei commented on a diff in pull request #4480: Close the thrift connection of KyuubiServer when backend engine is determined as dead by EngineAliveProbe

["risyomei (via GitHub)" <gi...@apache.org>]

risyomei commented on code in PR #4480:
URL: https://github.com/apache/kyuubi/pull/4480#discussion_r1128994572


##########
kyuubi-server/src/main/scala/org/apache/kyuubi/client/KyuubiSyncThriftClient.scala:
##########
@@ -43,7 +43,8 @@ class KyuubiSyncThriftClient private (
     protocol: TProtocol,
     engineAliveProbeProtocol: Option[TProtocol],
     engineAliveProbeInterval: Long,
-    engineAliveTimeout: Long)
+    engineAliveTimeout: Long,
+    engineAliveCloseConnection: Boolean = false)

Review Comment:
   Setting a default value here for better compatibility. 
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org