You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hop.apache.org by GitBox <gi...@apache.org> on 2022/03/11 22:32:34 UTC
[GitHub] [hop] sramazzina opened a new pull request #1419: HOP-3842
sramazzina opened a new pull request #1419:
URL: https://github.com/apache/hop/pull/1419
HOP-3842 PipelineExecutor: wrong groupBuffer initialization
Following this checklist to help us incorporate your contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/HOP) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[HOP-XXX] - Fixes bug in SessionManager`,
where you replace `HOP-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the commit message.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [ ] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`.
Trivial changes like typos do not require a JIRA issue (javadoc, comments...).
In this case, just format the pull request title like `(DOC) - Add javadoc in SessionManager`.
If this is your first contribution, you have to read the [Contribution Guidelines](https://hop.apache.org/community/contributing/)
If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf)
if you are unsure please ask on the developers list.
To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hop] sramazzina commented on pull request #1419: HOP-3842
Posted by GitBox <gi...@apache.org>.
sramazzina commented on pull request #1419:
URL: https://github.com/apache/hop/pull/1419#issuecomment-1066509710
The only tests we can add are unit tests and not integration tests or do tou have a different idea?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hop] hansva commented on pull request #1419: HOP-3842
Posted by GitBox <gi...@apache.org>.
hansva commented on pull request #1419:
URL: https://github.com/apache/hop/pull/1419#issuecomment-1065599146
Can we add some tests to this? A couple of pipelines with different group settings and check if the incoming data is correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hop] hansva commented on pull request #1419: HOP-3842
Posted by GitBox <gi...@apache.org>.
hansva commented on pull request #1419:
URL: https://github.com/apache/hop/pull/1419#issuecomment-1066524434
As discussed.
We can create a couple of test to send groups of data to the sub-pipeline and count the number of rows we are expecting on the "Get rows from result"
We have to do this on both a static sub-pipeline as dynamic, and what happens if we have a group of 4 lines and the template changes on line 3.
If we lock this in integration tests then we have examples on what is expected behaviour
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org