You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/03/05 18:22:52 UTC

[GitHub] [cloudstack] GabrielBrascher opened a new pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

GabrielBrascher opened a new pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600


   ## Description
   <!--- Describe your changes in detail -->
   This proposal allows Virtual Routers to be deployed on disabled zones/pods/clusters. It also gives the opportunity to deploy Admin VMs to be deployed on disabled resources.
   
   The default configuration is set to **false** for deploying Admin VMs on disabled resources and deploying system VMs on disabled resources. Both, `allow.router.on.disabled.resources` and `allow.admin.vm.on.disabled.resources`, are configurable and do not require management server restart when updated.
   
   The main goal of this implementation is to give flexibility and total control for system admins to decide either if they want or not to deploy System and/or Admin VMs in disabled resources. This implementation was encouraged after an issue related with a disabled Pod; it was not possible to reset networks in the Zone due to the fact that the VRs running on the disabled Pods would fail to be re-deployed.
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [x] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-717826198


   @blueorangutan test


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] GabrielBrascher commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-718204637


   It still the same error on blueoragutan tests even after merge/rebase with latest master. Let me check this again.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-698768633






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] GabrielBrascher commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-713740765


   I am going to take a look at it today. Thanks for the ping @DaanHoogland!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-705774521


   <b>Trillian test result (tid-2911)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 39748 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3600-t2911-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_affinity_groups_projects.py
   Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_projects.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 81 look OK, 4 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_DeployVmAntiAffinityGroup_in_project | `Error` | 1.35 | test_affinity_groups_projects.py
   test_09_project_suspend | `Error` | 2.49 | test_projects.py
   test_10_project_activation | `Error` | 2.36 | test_projects.py
   test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 300.55 | test_vpc_redundant.py
   test_hostha_kvm_host_fencing | `Error` | 175.95 | test_hostha_kvm.py
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-819941057


   <b>Trillian test result (tid-442)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 32310 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3600-t442-kvm-centos7.zip
   Smoke tests completed. 88 look OK, 0 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] GabrielBrascher commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-648301550


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-713096399


   Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2234


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-698769190


   @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] GabrielBrascher edited a comment on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
GabrielBrascher edited a comment on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-849022193


   Again annoying with some _pinging for review_: @DaanHoogland @andrijapanicsb @PaulAngus @svenvogel @RodrigoDLopez @GutoVeronezi @weizhouapache @ravening @rhtyd & others
   
   I appreciate any feedback. Thanks in advance :-)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-696574117


   two oks so it should be , but it has been laying in the cellar to mature for quite a while, so let me check how stale it is:
   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-817861889


   Packaging result: :heavy_multiplication_x: centos7 :heavy_multiplication_x: centos8 :heavy_multiplication_x: debian. SL-JID 398


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-697888006


   @blueorangutan test


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] slavkap commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
slavkap commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-850198411


   Thank you too @andrijapanicsb! I didn't know this one :)
   The VR is recreated on the disabled zone/pod/cluster when I restart the network with those options:
   allow.admin.vm.on.disabled.resources = false
   allow.router.on.disabled.resources = true


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] GabrielBrascher commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-819582442


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-791601862


   @DaanHoogland unsupported parameters provided. Supported mgmt server os are: `centos6, centos7, centos8, ubuntu`. Supported hypervisors are: `kvm-centos6, kvm-centos7, kvm-centos8, kvm-ubuntu, xenserver-71, xenserver-65sp1, vmware-67u3, vmware-65u2, vmware-60u2, vmware-55u3, xcpng76, xcpng80, xcpng81, xenserver-74, xcpng74`


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-817234066


   Packaging result: :heavy_multiplication_x: centos7 :heavy_multiplication_x: centos8 :heavy_multiplication_x: debian. SL-JID 382


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-704196543


   @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-704196145


   @blueorangutan test


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland merged pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
DaanHoogland merged pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] GabrielBrascher commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-849184776


   @PaulAngus you are right. There has not been added smoke test.
   
   @andrijapanicsb I really appreciate any tests. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] GabrielBrascher commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-817846155


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] GabrielBrascher edited a comment on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
GabrielBrascher edited a comment on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-648280999


   @andrijapanicsb @DaanHoogland I just rebased and fixed all conflicts, the branch is good for master/4.15.
   
   Note: I have executed a batch of manual tests on a 4.15-SNAPSHOT Zone. All looking good!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-705395445


   @blueorangutan test


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-725405295


   @blueorangutan test


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-648318939


   Packaging result: ✔centos7 ✔debian. JID-1437


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] GabrielBrascher commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-699384261


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] GabrielBrascher commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-648283519


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on a change in pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#discussion_r521181416



##########
File path: server/src/main/java/com/cloud/deploy/DeploymentPlanningManagerImpl.java
##########
@@ -574,6 +580,80 @@ private boolean getDisplayStorageFromVmProfile(VirtualMachineProfile vmProfile)
         return vmProfile == null || vmProfile.getTemplate() == null || !vmProfile.getTemplate().isDeployAsIs();
     }
 
+        /**
+         * Adds disabled resources (Data centers, Pods, Clusters, and hosts) to exclude list (avoid) in case of disabled state.
+         */
+        public void avoidDisabledResources(VirtualMachineProfile vmProfile, DataCenter dc, ExcludeList avoids) {
+            if (vmProfile.getType().isUsedBySystem() && isRouterDeployableInDisabledResources()) {
+                return;
+            }
+
+            VMInstanceVO vm = _vmInstanceDao.findById(vmProfile.getId());
+            AccountVO owner = accountDao.findById(vm.getAccountId());
+            if (owner.getRoleId() == ADMIN_ACCOUNT_ROLE_ID && isAdminVmDeployableInDisabledResources()) {

Review comment:
       @DaanHoogland the problem raised by the tests is due to the fact that the role ID of a project is null; thus, these tests are failing.
   
   Tests that failed:
   /marvin/tests/smoke/test_affinity_groups_projects.py
   /marvin/tests/smoke/test_kubernetes_clusters.py
   /marvin/tests/smoke/test_projects.py
   I am going to take a look at a fix for it, not sure if this will be on 4.15 then. Is there an ETA for 4.15?
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-713352379


   @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-696574720


   @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-725405532


   @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-698768633


   @blueorangutan test


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland edited a comment on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
DaanHoogland edited a comment on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-698840369


   @GabrielBrascher it keeps failing as our lab is to busy. did you run integration tests on this? (cc @PaulAngus )
   Can you check the travis failures while you're at it?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] GabrielBrascher commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-725390388


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-705395821


   @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] GabrielBrascher commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-648280999


   @andrijapanicsb @DaanHoogland I just rebased and fixed all conflicts, branch good for master/4.15 now.
   
   Note: I have executed a batch of manual tests on a 4.15-SNAPSHOT Zone. All looking good!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan removed a comment on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-718186623






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-717826917


   @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-703577674


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-713715309


   <b>Trillian test result (tid-3031)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 33980 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3600-t3031-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_affinity_groups_projects.py
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_projects.py
   Smoke tests completed. 82 look OK, 3 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_DeployVmAntiAffinityGroup_in_project | `Error` | 1.36 | test_affinity_groups_projects.py
   test_03_deploy_and_upgrade_kubernetes_cluster | `Failure` | 248.35 | test_kubernetes_clusters.py
   test_09_project_suspend | `Error` | 2.51 | test_projects.py
   test_10_project_activation | `Error` | 2.37 | test_projects.py
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-819600115


   Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 412


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-712768033


   rebuilding on latest changes
   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-699385466


   @GabrielBrascher a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] GabrielBrascher closed pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
GabrielBrascher closed pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-819604028


   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-849566416


   Do I need to re-review @GabrielBrascher ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] GabrielBrascher commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-850053383


   Thanks for testing, @slavkap. @andrijapanicsb you are right :-)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-819604315


   @shwstppr a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-705395445


   @blueorangutan test


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-850241601


   @slavkap are you :ok: (:+1:) with this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan removed a comment on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-717789959


   @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] slavkap commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
slavkap commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-850246673


   yes, @DaanHoogland, it works as expected, and also I like this enhancement :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-819583996


   @GabrielBrascher a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] andrijapanicsb commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-849094901


   Very valid point by Paul @GabrielBrascher  (have smoke tests been added for this?)
   I will try to test this tomorrow manually (building an anv now)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-713050732


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-713730487


   @GabrielBrascher the test_project errors are consistent, can you have a look?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-696574720






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] GabrielBrascher closed pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
GabrielBrascher closed pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-703600842


   Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2116


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-817233486


   @GabrielBrascher a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] GabrielBrascher removed a comment on pull request #3600: Allow deploy Admin VMs annd VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
GabrielBrascher removed a comment on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-599496797


   Sorry for the radio silence, I was sick last Friday. Better now at least ;-)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-698769190


   @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-725695058


   <b>Trillian test result (tid-3155)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 32507 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3600-t3155-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Smoke tests completed. 85 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_04_rvpc_privategw_static_routes | `Failure` | 914.38 | test_privategw_acl.py
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-717821376


   Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2289


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-713352131


   @blueorangutan test


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland removed a comment on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
DaanHoogland removed a comment on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-717826198






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#discussion_r521203796



##########
File path: server/src/main/java/com/cloud/deploy/DeploymentPlanningManagerImpl.java
##########
@@ -574,6 +580,80 @@ private boolean getDisplayStorageFromVmProfile(VirtualMachineProfile vmProfile)
         return vmProfile == null || vmProfile.getTemplate() == null || !vmProfile.getTemplate().isDeployAsIs();
     }
 
+        /**
+         * Adds disabled resources (Data centers, Pods, Clusters, and hosts) to exclude list (avoid) in case of disabled state.
+         */
+        public void avoidDisabledResources(VirtualMachineProfile vmProfile, DataCenter dc, ExcludeList avoids) {
+            if (vmProfile.getType().isUsedBySystem() && isRouterDeployableInDisabledResources()) {
+                return;
+            }
+
+            VMInstanceVO vm = _vmInstanceDao.findById(vmProfile.getId());
+            AccountVO owner = accountDao.findById(vm.getAccountId());
+            if (owner.getRoleId() == ADMIN_ACCOUNT_ROLE_ID && isAdminVmDeployableInDisabledResources()) {

Review comment:
       :) last month, @GabrielBrascher 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on a change in pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#discussion_r521316685



##########
File path: server/src/main/java/com/cloud/deploy/DeploymentPlanningManagerImpl.java
##########
@@ -574,6 +580,86 @@ private boolean getDisplayStorageFromVmProfile(VirtualMachineProfile vmProfile)
         return vmProfile == null || vmProfile.getTemplate() == null || !vmProfile.getTemplate().isDeployAsIs();
     }
 
+        /**
+         * Adds disabled resources (Data centers, Pods, Clusters, and hosts) to exclude list (avoid) in case of disabled state.
+         */
+        public void avoidDisabledResources(VirtualMachineProfile vmProfile, DataCenter dc, ExcludeList avoids) {
+            if (vmProfile.getType().isUsedBySystem() && isRouterDeployableInDisabledResources()) {
+                return;
+            }
+
+            VMInstanceVO vm = _vmInstanceDao.findById(vmProfile.getId());
+            AccountVO owner = accountDao.findById(vm.getAccountId());
+            boolean isOwnerRoleIdAdmin = false;
+
+            if (owner != null && owner.getRoleId() != null && owner.getRoleId() == ADMIN_ACCOUNT_ROLE_ID) {

Review comment:
       @DaanHoogland I fixed the issue raised on tests regarding VMs deployed on a project.
   
   Manual tests are looking good now; thanks :-)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-712791940


   Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2216


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-648299420


   Packaging result: ✔centos7 ✖debian. JID-1435


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-712768735


   @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-713051577


   @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] andrijapanicsb commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-850029000


   @slavkap you can restart the network (or VPC if it's a VPC) with "clean up" - it will first try to create a new VR, later destroy the old one - see if the new new VR ge's created immediately.
   
   Btw, since you tested this manually, and since I did not have time today to test it myself- I will be lazy now and thank you for the manual tests you've done :)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] slavkap commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
slavkap commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-849718805


   @GabrielBrascher, I did manual tests
   
   **disabled Zone:**
   deploy of a VM - works
   recreate a VR - works
   recreate of CPVM/SSVM - doesn't
   
   **disabled Pod:**
   deploy of a VM - works
   recreate a VR - works
   recreate of CPVM/SSVM - works
   
   **disabled Cluster:**
   deploy of a VM - works
   recreate a VR - works
   recreate of CPVM/SSVM - works
   
   But I'm not sure how to test with the below set up to deploy a new VR without deploying a guest VM?
   
   allow.admin.vm.on.disabled.resources = false
   allow.router.on.disabled.resources = true
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-705395821






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-696591046


   Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2063


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-725390906


   @GabrielBrascher a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland edited a comment on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
DaanHoogland edited a comment on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-698840369


   @GabrielBrascher it keeps failing as our lab is to busy. did you run integration tests on this? (cc @PaulAngus )
   Can you check the travis failures while you're at it?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] GabrielBrascher commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-701730567


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] GabrielBrascher commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-820559105


   Thanks, @shwstppr! Tests are looking good :+1:


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-818536091


   Packaging result: :heavy_multiplication_x: centos7 :heavy_multiplication_x: centos8 :heavy_multiplication_x: debian. SL-JID 404


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] GabrielBrascher commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-696141674


   @andrijapanicsb @rhtyd @DaanHoogland is this one ready for merge?
   Let me know if there is anything else that I should address on this PR :-)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland removed a comment on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
DaanHoogland removed a comment on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-725390327


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-648302137


   @GabrielBrascher a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-724926519


   ping @GabrielBrascher will you have time to address this (be)for(e) 4.15?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-696574117


   two oks so it should be , but it has been laying in the cellar to mature for quite a while, so let me check how stale it is:
   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-717789605


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-698840369


   @GabrielBrascher it keeps failing as our lab is to busy. did you run integration tests on this? (cc @PaulAngus )


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-725390327


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-699426270


   Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2088


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] GabrielBrascher commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-791598253


   @blueorangutan test


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] GabrielBrascher closed pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
GabrielBrascher closed pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] GabrielBrascher commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-817233453


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-717789959


   @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] GabrielBrascher commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-701730680


   Fixed conflict with Master.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] GabrielBrascher commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-849022193


   Again annoying with some _pinging for review_: @DaanHoogland @andrijapanicsb @PaulAngus @svenvogel @RodrigoDLopez @GutoVeronezi @weizhouapache @ravening @rhtyd & others
   
   This one completed 1 year in April :cake: :birthday: :balloon: :laughing:. I appreciate any feedback.
   Thanks in advance :-)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-703577938


   @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-697888974


   @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-725404871


   Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2367


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-817847191


   @GabrielBrascher a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] PaulAngus commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
PaulAngus commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-849076966


   Have specific Marvin tests been added for this?  Otherwise, a BlueOrangutan run won't determine if the feature actually works as required i.e. manual tests need to be recorded.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-791601461


   > @blueorangutan test
   
   pretty sure this is not needed or possible, @GabrielBrascher 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan removed a comment on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-717821376


   Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2289


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-708435531


   not sure what still needs to be done here... @GabrielBrascher @andrijapanicsb @rhtyd ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] GabrielBrascher commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-696141674


   @andrijapanicsb @rhtyd @DaanHoogland is this one ready for merge?
   Let me know if there is anything else that I should address on this PR :-)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-648284180


   @GabrielBrascher a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org