[GitHub] [skywalking-python] tom-pytel edited a comment on pull request #122: WIP initial psycopg plugin

[GitBox <gi...@apache.org>]

tom-pytel edited a comment on pull request #122:
URL: https://github.com/apache/skywalking-python/pull/122#issuecomment-855406558


   Ok, one thing to resolve before merge. I reused `config.mysql_trace_sql_parameters` and `config.mysql_sql_parameters_max_length` options in this plugin just to get it running but the final param should be one of two cases:
   1. Add separate `config.postgre_trace_sql_parameters` and `config.postgre_sql_parameters_max_length`.
   2. Convert `config.mysql_trace_sql_parameters` to just `config.trace_sql_parameters` as well as the length option and have all SQL agents share this to avoid explosion of options as different SQL agents are added (since odds are you will not be using mysql and postgresql simultaneously in the same project) - this is my preferred option.
   
   And another idea unrelated to which option above is taken. If you are not locked into the current options scheme - reduce the two parameters `config.mysql_trace_sql_parameters` and `config.mysql_sql_parameters_max_length` into a single option `config.mysql_parameters` (or something like that) which gives the length and if length 0 is specified (default) then disables parameters?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org