Struts Nightly Build 2000/06/11

[Ralph Schaer <rs...@datacomm.ch>]

Hello

There is an error in the textarea tag (org.apache.struts.taglib.TextareaTag)

Missing blank between <textarea and name=...

Line 110:
 StringBuffer results = new StringBuffer("<textarea");
 results.append("name=\"");


There is also a difference between the documentation (tags.html) and the
tld (struts.tld)

In the documentation the textarea tag has the attributes cols, name, rows
and value
But the tld describe the tag with the following attributes: maxlength, name,
size, value

Re: Struts Nightly Build 2000/06/11

[Kare Nuorteva <ka...@satama.com>]

Ralph Schaer wrote:
> 
> Hello
> 
> There is an error in the textarea tag (org.apache.struts.taglib.TextareaTag)
> 
> Missing blank between <textarea and name=...
> 
> Line 110:
>  StringBuffer results = new StringBuffer("<textarea");
>  results.append("name=\"");
> 

The following patch should fix the problem. I didn't go through heavy
testing process :)

Index: src/share/org/apache/struts/taglib/TextareaTag.java
===================================================================
RCS file:
/home/cvspublic/jakarta-struts/src/share/org/apache/struts/taglib/TextareaTag.java,v
retrieving revision 1.1.1.1
diff -r1.1.1.1 TextareaTag.java
111c111
< 	results.append("name=\"");
---
> 	results.append(" name=\"");



> There is also a difference between the documentation (tags.html) and the
> tld (struts.tld)
> 
> In the documentation the textarea tag has the attributes cols, name, rows
> and value
> But the tld describe the tag with the following attributes: maxlength, name,
> size, value

Not shure about this, but sounds like the documentation is more right
(at least makes sense to me).

Br,

Kare 8^)

-- 
Kare Nuorteva, Software Engineer
Satama UK Ltd
mobile +44 7989 852 865
http://www.satama.co.uk/

Re: Struts Nightly Build 2000/06/11

["Craig R. McClanahan" <Cr...@eng.sun.com>]

Ralph Schaer wrote:

> Hello
>
> There is an error in the textarea tag (org.apache.struts.taglib.TextareaTag)
>
> Missing blank between <textarea and name=...
>
> Line 110:
>  StringBuffer results = new StringBuffer("<textarea");
>  results.append("name=\"");
>

Thanks ... this will be fixed in tonight's build.

>
> There is also a difference between the documentation (tags.html) and the
> tld (struts.tld)
>
> In the documentation the textarea tag has the attributes cols, name, rows
> and value
> But the tld describe the tag with the following attributes: maxlength, name,
> size, value

This will also be fixed.

Craig