[GitHub] [kafka] showuon commented on pull request #13572: KAFKA-14908: Set setReuseAddress on the kafka server socket

["showuon (via GitHub)" <gi...@apache.org>]

showuon commented on PR #13572:
URL: https://github.com/apache/kafka/pull/13572#issuecomment-1512813175

   @divijvaidya , thanks for the comment. I agree with you most of them. But for this point:
   > I would suggest to extract out a method "createSocketServerChannel()" in SocketServer.java. This method would create the channel and set the configuration on the socket. Use this same method in all the tests.
   
   Since the `SelectorTest` and other network tests are in client module, we should not add `core` dependency to `client` module. So, I think adding a util method in `TestUtils` should be good enough. WDYT?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org