You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "FlyingZC (via GitHub)" <gi...@apache.org> on 2023/07/13 06:15:14 UTC

[GitHub] [shardingsphere] FlyingZC opened a new issue, #26960: Support parsing Oracle ALTER DISKGROUP sql

FlyingZC opened a new issue, #26960:
URL: https://github.com/apache/shardingsphere/issues/26960

   # Background
   Hi community,
   This issue is for #26878.
   
   ShardingSphere parser engine helps users parse a SQL to get the AST (Abstract Syntax Tree) and visit this tree to get SQLStatement (Java Object). Currently, we are planning to enhance the support for Oracle SQL parsing in ShardingSphere.
   
   More details:
   https://shardingsphere.apache.org/document/current/en/reference/sharding/parse/
   
   # Task
   This issue is to support more oracle sql parse, as follows:
   ```sql
   ALTER DISKGROUP data OFFLINE DISK IN FAILGROUP FG2;
   ```
   
   ```sql
   ALTER DISKGROUP data ADD TEMPLATE datafile_hot
     ATTRIBUTE ( 
       HOT
       MIRRORHOT);
   ```
   
   ```sql
   ALTER DATABASE DISABLE BLOCK CHANGE TRACKING;
   ```
   
   ```sql
   ALTER DISKGROUP data OFFLINE DISK DATA_001 DROP AFTER 5m;
   ```
   
   ```sql
   ALTER DISKGROUP data MODIFY USERGROUP 'test_grp2' DROP MEMBER 'oracle2';
   ```
   
   # Process
   1. First confirm that this is a correct oracle sql syntax, if not please ignore;
   2. Compare SQL definitions in Oficial SQL Doc and ShardingSphere SQL Doc;
   3. If there is any difference in ShardingSphere SQL Doc, please correct them by referring to the Official SQL Doc;
   4. Run mvn install the current_file_module;
   5. Check whether there are any exceptions. If indeed, please fix them. (Especially xxxVisitor.class);
   6. Add new corresponding SQL case in SQL Cases and expected parsed result in Expected Statment XML;
   7. Run SQLParserParameterizedTest to make sure no exceptions.
   
   # Relevant Skills
   1. Master JAVA language
   2. Have a basic understanding of Antlr `g4` file
   3. Be familiar with Oracle SQLs


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] zihaoAK47 commented on issue #26960: Support parsing Oracle ALTER DISKGROUP sql

Posted by "zihaoAK47 (via GitHub)" <gi...@apache.org>.
zihaoAK47 commented on issue #26960:
URL: https://github.com/apache/shardingsphere/issues/26960#issuecomment-1648905989

   @strongduanmu Hi mentor, please assign it to me thank you


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] zihaoAK47 commented on issue #26960: Support parsing Oracle ALTER DISKGROUP sql

Posted by "zihaoAK47 (via GitHub)" <gi...@apache.org>.
zihaoAK47 commented on issue #26960:
URL: https://github.com/apache/shardingsphere/issues/26960#issuecomment-1649493364

   Error sql: ALTER DISKGROUP data OFFLINE DISK IN FAILGROUP FG2;
   
   SQL> ALTER DISKGROUP data OFFLINE DISK IN FAILGROUP FG2;
   ALTER DISKGROUP data OFFLINE DISK IN FAILGROUP FG2
                                        *
   ERROR at line 1:
   ORA-00905: missing keyword


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] strongduanmu closed issue #26960: Support parsing Oracle ALTER DISKGROUP sql

Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu closed issue #26960: Support parsing Oracle ALTER DISKGROUP sql
URL: https://github.com/apache/shardingsphere/issues/26960


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org