You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@libcloud.apache.org by fjros <gi...@git.apache.org> on 2017/04/27 18:10:48 UTC

[GitHub] libcloud pull request #1047: Fix GCENodeDriver.ex_get_volume() when zone par...

GitHub user fjros opened a pull request:

    https://github.com/apache/libcloud/pull/1047

    Fix GCENodeDriver.ex_get_volume() when zone param is of class GCEZone or NodeLocation

    ## Fix GCENodeDriver.ex_get_volume() when zone param is of class GCEZone or NodeLocation
    
    ### Description
    
    Use the zone name (not a zone object) when looking up a volume in the GCE compute driver. This PR makes the method compliant with its documentation.
    
    ### Status
    
    - done, ready for review
    
    ### Checklist (tick everything that applies)
    
    - [ ] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide) (required, can be done after the PR checks)
    - [ ] Documentation
    - [ ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
    - [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes) (required for bigger changes)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/fjros/libcloud fix-gce-get-volume

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/1047.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1047
    
----
commit 9329167489a9fa80dc03e0f6a03760c63278862e
Author: Francisco Ros <fj...@doalitic.com>
Date:   2017-04-27T17:57:16Z

    Fix GCENodeDriver.ex_get_volume() if zone param is GCEZone or NodeLocation

commit fafb6fbfce2489ba1cb720db61ab4b0ba13b3ea4
Author: Francisco Ros <fj...@doalitic.com>
Date:   2017-04-27T17:58:42Z

    Add test to check that can get gce volume at a given zone

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] libcloud pull request #1047: Fix GCENodeDriver.ex_get_volume() when zone par...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/libcloud/pull/1047


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---