You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/12/11 09:21:44 UTC

[GitHub] [flink] wuchong commented on a change in pull request #14369: [FLINK-20570][docs] Fix the `NOTE` tip style in process_function page

wuchong commented on a change in pull request #14369:
URL: https://github.com/apache/flink/pull/14369#discussion_r540803279



##########
File path: docs/dev/stream/operators/process_function.md
##########
@@ -246,10 +246,8 @@ class CountWithTimeoutFunction extends KeyedProcessFunction[Tuple, (String, Stri
 </div>
 </div>
 
-{% top %}
-
 
-**NOTE:** Before Flink 1.4.0, when called from a processing-time timer, the `ProcessFunction.onTimer()` method sets
+<span class="label label-info">Note</span> Before Flink 1.4.0, when called from a processing-time timer, the `ProcessFunction.onTimer()` method sets

Review comment:
       I think `**NOTE:**` is used in more places?

##########
File path: docs/dev/stream/operators/process_function.md
##########
@@ -246,10 +246,8 @@ class CountWithTimeoutFunction extends KeyedProcessFunction[Tuple, (String, Stri
 </div>
 </div>
 
-{% top %}

Review comment:
       This is useful to scroll to the page top. You can find the top link is used in many places.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org