You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by Dan Milstein <da...@shore.net> on 2000/12/05 05:47:21 UTC

[PATCH] Code Cleanup/Reorg for Ajp13 Class

I've just completed a major cleanup/reorganization of:

org.apache.tomcat.modules.server.Ajp13

In the jakarta-tomcat branch, which I'm attaching as a patch against the current version.  I have done MINIMAL testing, since I am very new to working on Tomcat, and I don't know what a standard set of tests might be (or if one exists).  I have verified that Tomcat can still talk to Apache, and that basic request info is being transfered.  That's about all I've been able to do.

The main goal of the rewrite was to clarify what is going on.  To that end, I added a lot of comments, and moved some code around to clarify what it was doing.  I also: 

 - Fixed a minor bug in headerNameToSc -- response headers of type "WWW-Authenticate" were not being encoded as integers, because of a typo in the Java code.  Note that the old behavior was less efficient (it would send the entire "WWW-Authenticate" string), but not incorrect.

 - Cleaned up all the import statements
 
 - Stripped some unused code out of the internal Ajp13Packet class.

 - Moved a lot of functionality out of tomcat.util.BuffTool into Ajp13Packet (where it seemed much more natural).  I believe that BuffTool can now be safely deleted (I just deleted it and built Tomcat with no problems).
 
Enjoy,
-Dan

-- 
Dan Milstein // danmil@shore.net