You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "patsonluk (via GitHub)" <gi...@apache.org> on 2023/06/29 00:00:09 UTC
[GitHub] [solr] patsonluk opened a new pull request, #1735: SOLR-16582 : Documentation for logging filter on SolrCore
patsonluk opened a new pull request, #1735:
URL: https://github.com/apache/solr/pull/1735
https://issues.apache.org/jira/browse/SOLR-16582
# Description
Added documentation to #1229
Please review the following and check all that apply:
- [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [x] I have created a Jira issue and added the issue ID to my pull request title.
- [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [x] I have developed this patch against the `main` branch.
- [ ] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
- [x] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] patsonluk commented on a diff in pull request #1735: SOLR-16582 : Documentation for logging filter on SolrCore
Posted by "patsonluk (via GitHub)" <gi...@apache.org>.
patsonluk commented on code in PR #1735:
URL: https://github.com/apache/solr/pull/1735#discussion_r1246819937
##########
solr/solr-ref-guide/modules/deployment-guide/pages/configuring-logging.adoc:
##########
@@ -172,6 +172,22 @@ The log file under which you can find all these queries is called `solr_slow_req
In addition to the logging options described above, it's possible to log only a selected list of request parameters (such as those sent with queries) with an additional request parameter called `logParamsList`.
See the section on xref:query-guide:common-query-parameters.adoc#logparamslist-parameter[logParamsList Parameter] for more information.
+== Selective Logging on SolrCore
+
+It can sometimes be noisy when `SolrCore` logs info on every response. Selective logging can be configured on SolrCore by using the `MarkerFilter` on request paths in `log4j2.xml`.
Review Comment:
Thank you for the suggestion! I have taken most of ur text and rewrote it, can you please take a look again? 😊
The marker was only added to SolrCore, as it was the one that produces too much log for us (we have hundreds of cores per node and replication can create be noisy for us)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] gerlowskija commented on a diff in pull request #1735: SOLR-16582 : Documentation for logging filter on SolrCore
Posted by "gerlowskija (via GitHub)" <gi...@apache.org>.
gerlowskija commented on code in PR #1735:
URL: https://github.com/apache/solr/pull/1735#discussion_r1246740973
##########
solr/solr-ref-guide/modules/deployment-guide/pages/configuring-logging.adoc:
##########
@@ -172,6 +172,22 @@ The log file under which you can find all these queries is called `solr_slow_req
In addition to the logging options described above, it's possible to log only a selected list of request parameters (such as those sent with queries) with an additional request parameter called `logParamsList`.
See the section on xref:query-guide:common-query-parameters.adoc#logparamslist-parameter[logParamsList Parameter] for more information.
+== Selective Logging on SolrCore
+
+It can sometimes be noisy when `SolrCore` logs info on every response. Selective logging can be configured on SolrCore by using the `MarkerFilter` on request paths in `log4j2.xml`.
Review Comment:
[0] Would a reader necessarily know what "SolrCore logs" are? (i.e. that these are Solr's request logs). Or would it be better to call that out a bit more explicitly?
> Solr logs all core/collection requests at INFO level using the `o.a.s.c.SolrCore.Request` and `o.a.s.c.SolrCore.SlowRequest` loggers. This can be disabled entirely by changing the level of these loggers to `WARN` or `ERROR`, or administrators can configure more selective request logging on a per-path basis by using `MarkerFilter`...
[Q] Is the marker stuff really only for the request logging in SolrCore, or is it also used for the HttpSolrCall request logging that's used for non-core (i.e. admin) requests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] gerlowskija merged pull request #1735: SOLR-16582 : Documentation for logging filter on SolrCore
Posted by "gerlowskija (via GitHub)" <gi...@apache.org>.
gerlowskija merged PR #1735:
URL: https://github.com/apache/solr/pull/1735
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] patsonluk commented on a diff in pull request #1735: SOLR-16582 : Documentation for logging filter on SolrCore
Posted by "patsonluk (via GitHub)" <gi...@apache.org>.
patsonluk commented on code in PR #1735:
URL: https://github.com/apache/solr/pull/1735#discussion_r1246819937
##########
solr/solr-ref-guide/modules/deployment-guide/pages/configuring-logging.adoc:
##########
@@ -172,6 +172,22 @@ The log file under which you can find all these queries is called `solr_slow_req
In addition to the logging options described above, it's possible to log only a selected list of request parameters (such as those sent with queries) with an additional request parameter called `logParamsList`.
See the section on xref:query-guide:common-query-parameters.adoc#logparamslist-parameter[logParamsList Parameter] for more information.
+== Selective Logging on SolrCore
+
+It can sometimes be noisy when `SolrCore` logs info on every response. Selective logging can be configured on SolrCore by using the `MarkerFilter` on request paths in `log4j2.xml`.
Review Comment:
Thank you for the suggestion! I have taken most of ur text and rewrote it, can you please take a look again? 😊
The marker was only added to SolrCore, as it was the one that produces too much log for us (we have hundreds of cores per node and replication can be noisy)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] gerlowskija commented on a diff in pull request #1735: SOLR-16582 : Documentation for logging filter on SolrCore
Posted by "gerlowskija (via GitHub)" <gi...@apache.org>.
gerlowskija commented on code in PR #1735:
URL: https://github.com/apache/solr/pull/1735#discussion_r1246902053
##########
solr/solr-ref-guide/modules/deployment-guide/pages/configuring-logging.adoc:
##########
@@ -172,6 +172,22 @@ The log file under which you can find all these queries is called `solr_slow_req
In addition to the logging options described above, it's possible to log only a selected list of request parameters (such as those sent with queries) with an additional request parameter called `logParamsList`.
See the section on xref:query-guide:common-query-parameters.adoc#logparamslist-parameter[logParamsList Parameter] for more information.
+== Selective Logging on SolrCore
+
+It can sometimes be noisy when `SolrCore` logs info on every response. Selective logging can be configured on SolrCore by using the `MarkerFilter` on request paths in `log4j2.xml`.
Review Comment:
LGTM, thanks for adjusting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] patsonluk commented on pull request #1735: SOLR-16582 : Documentation for logging filter on SolrCore
Posted by "patsonluk (via GitHub)" <gi...@apache.org>.
patsonluk commented on PR #1735:
URL: https://github.com/apache/solr/pull/1735#issuecomment-1612255169
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org