[GitHub] [activemq-nms-amqp] Havret commented on issue #9: [PoC] Testing toolkit

[GitBox <gi...@apache.org>]

Havret commented on issue #9: [PoC] Testing toolkit
URL: https://github.com/apache/activemq-nms-amqp/pull/9#issuecomment-518020984
 
 
   I've made some progress with this over the weekend and managed to write bits necessary to test message consumers. 
   
   It's quite enlightening as I localized another small issue with current implementation bca90d7 (already fixed) and one discrepancy between our implementation and qpid a6a4d96.
   
   When there are some unacknowledged messages and we decide to close consumer, qpid is explicitly sending Release Disposition frame for all buffered but unprocessed messages. We don't. ```TestCloseDurableSubscriberWithUnackedAndUnconsumedPrefetchedMessages``` is failing because of that. It could be quite easy to address it if we explicitly release all the buffered messages. But what should happen with messages that were handled over to the application? In qpid there is this concept of deferred close implemented. https://github.com/apache/qpid-jms/blob/f212e7c2c3e21d44e90068f9c0bf6ab374a68f8e/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/AmqpConsumer.java#L70-L80 
   
   Not sure if I should bother about this right now, or just simply fix it by releasing prefetched messages the same way as I did for transaction post rollback.
   
   @cjwmorgan-sol @michaelandrepearce What do you think? 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services