[GitHub] [incubator-nuttx-apps] btashton commented on a change in pull request #779: examples/qencoder: fix nxstyle warning and errors

[GitBox <gi...@apache.org>]

btashton commented on a change in pull request #779:
URL: https://github.com/apache/incubator-nuttx-apps/pull/779#discussion_r652309043



##########
File path: examples/qencoder/qe_main.c
##########
@@ -242,7 +242,7 @@ int main(int argc, FAR char *argv[])
     {
       printf("qe_main: open %s failed: %d\n", g_qeexample.devpath, errno);
       exitval = EXIT_FAILURE;
-      goto errout_with_dev;
+      goto errout;

Review comment:
       I think this line is actually the only change needed. The open fails we should just take the error path with no close. In the other cases we should take the path with the close. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org