You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "Philip Zeyliger (JIRA)" <ji...@apache.org> on 2009/12/31 02:35:29 UTC
[jira] Created: (AVRO-273) Stopwatch: simple class to encapsulate
time for statistics gathering
Stopwatch: simple class to encapsulate time for statistics gathering
--------------------------------------------------------------------
Key: AVRO-273
URL: https://issues.apache.org/jira/browse/AVRO-273
Project: Avro
Issue Type: New Feature
Components: java
Reporter: Philip Zeyliger
Assignee: Philip Zeyliger
Priority: Minor
To measure the duration of an RPC call, I need something that encapsulates the start and stop time. This is something simple that fits the bill.
The main thing I needed was the ability to swap out tick timers: otherwise things get unwieldy for testing.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (AVRO-273) Stopwatch: simple class to encapsulate
time for statistics gathering
Posted by "Philip Zeyliger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Philip Zeyliger updated AVRO-273:
---------------------------------
Attachment: AVRO-273.patch.txt
D'oh. Checkstyle was failing because of a missing "final" on a constant. Refreshing patch.
> Stopwatch: simple class to encapsulate time for statistics gathering
> --------------------------------------------------------------------
>
> Key: AVRO-273
> URL: https://issues.apache.org/jira/browse/AVRO-273
> Project: Avro
> Issue Type: New Feature
> Components: java
> Reporter: Philip Zeyliger
> Assignee: Philip Zeyliger
> Priority: Minor
> Attachments: AVRO-273.patch.txt, AVRO-273.patch.txt
>
>
> To measure the duration of an RPC call, I need something that encapsulates the start and stop time. This is something simple that fits the bill.
> The main thing I needed was the ability to swap out tick timers: otherwise things get unwieldy for testing.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (AVRO-273) Stopwatch: simple class to encapsulate
time for statistics gathering
Posted by "Philip Zeyliger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Philip Zeyliger updated AVRO-273:
---------------------------------
Status: Patch Available (was: Open)
> Stopwatch: simple class to encapsulate time for statistics gathering
> --------------------------------------------------------------------
>
> Key: AVRO-273
> URL: https://issues.apache.org/jira/browse/AVRO-273
> Project: Avro
> Issue Type: New Feature
> Components: java
> Reporter: Philip Zeyliger
> Assignee: Philip Zeyliger
> Priority: Minor
> Attachments: AVRO-273.patch.txt, AVRO-273.patch.txt
>
>
> To measure the duration of an RPC call, I need something that encapsulates the start and stop time. This is something simple that fits the bill.
> The main thing I needed was the ability to swap out tick timers: otherwise things get unwieldy for testing.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (AVRO-273) Stopwatch: simple class to encapsulate
time for statistics gathering
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Doug Cutting updated AVRO-273:
------------------------------
Resolution: Fixed
Fix Version/s: 1.3.0
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I just committed this. Thanks, Philip!
> Stopwatch: simple class to encapsulate time for statistics gathering
> --------------------------------------------------------------------
>
> Key: AVRO-273
> URL: https://issues.apache.org/jira/browse/AVRO-273
> Project: Avro
> Issue Type: New Feature
> Components: java
> Reporter: Philip Zeyliger
> Assignee: Philip Zeyliger
> Priority: Minor
> Fix For: 1.3.0
>
> Attachments: AVRO-273.patch.txt, AVRO-273.patch.txt, AVRO-273.patch.txt
>
>
> To measure the duration of an RPC call, I need something that encapsulates the start and stop time. This is something simple that fits the bill.
> The main thing I needed was the ability to swap out tick timers: otherwise things get unwieldy for testing.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (AVRO-273) Stopwatch: simple class to encapsulate
time for statistics gathering
Posted by "Philip Zeyliger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Philip Zeyliger updated AVRO-273:
---------------------------------
Attachment: AVRO-273.patch.txt
Attaching patch.
This is the first of the patches to introduce a new package ("org/apache/avro/ipc/stats"), which is where I'm sticking AVRO-270 specific stuff.
> Stopwatch: simple class to encapsulate time for statistics gathering
> --------------------------------------------------------------------
>
> Key: AVRO-273
> URL: https://issues.apache.org/jira/browse/AVRO-273
> Project: Avro
> Issue Type: New Feature
> Components: java
> Reporter: Philip Zeyliger
> Assignee: Philip Zeyliger
> Priority: Minor
> Attachments: AVRO-273.patch.txt
>
>
> To measure the duration of an RPC call, I need something that encapsulates the start and stop time. This is something simple that fits the bill.
> The main thing I needed was the ability to swap out tick timers: otherwise things get unwieldy for testing.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (AVRO-273) Stopwatch: simple class to encapsulate
time for statistics gathering
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Doug Cutting updated AVRO-273:
------------------------------
Status: Open (was: Patch Available)
This doesn't feel at home in the ipc package. I'd prefer this were either:
- included as a package-private class included in AVRO-273; or:
- moved to the util package, if we think it is of general utility to Avro developers.
> Stopwatch: simple class to encapsulate time for statistics gathering
> --------------------------------------------------------------------
>
> Key: AVRO-273
> URL: https://issues.apache.org/jira/browse/AVRO-273
> Project: Avro
> Issue Type: New Feature
> Components: java
> Reporter: Philip Zeyliger
> Assignee: Philip Zeyliger
> Priority: Minor
> Attachments: AVRO-273.patch.txt, AVRO-273.patch.txt
>
>
> To measure the duration of an RPC call, I need something that encapsulates the start and stop time. This is something simple that fits the bill.
> The main thing I needed was the ability to swap out tick timers: otherwise things get unwieldy for testing.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (AVRO-273) Stopwatch: simple class to encapsulate
time for statistics gathering
Posted by "Philip Zeyliger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Philip Zeyliger updated AVRO-273:
---------------------------------
Attachment: AVRO-273.patch.txt
I'm game with making this stuff package-private. (The only thing that would be public would be the StatsPlugin and StatsServlet themselves). The only changes between the patch files are:
{noformat}
-public class Stopwatch {
+class Stopwatch {
-public class FakeTicks implements Ticks {
+class FakeTicks implements Ticks {
{noformat}
> Stopwatch: simple class to encapsulate time for statistics gathering
> --------------------------------------------------------------------
>
> Key: AVRO-273
> URL: https://issues.apache.org/jira/browse/AVRO-273
> Project: Avro
> Issue Type: New Feature
> Components: java
> Reporter: Philip Zeyliger
> Assignee: Philip Zeyliger
> Priority: Minor
> Attachments: AVRO-273.patch.txt, AVRO-273.patch.txt, AVRO-273.patch.txt
>
>
> To measure the duration of an RPC call, I need something that encapsulates the start and stop time. This is something simple that fits the bill.
> The main thing I needed was the ability to swap out tick timers: otherwise things get unwieldy for testing.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (AVRO-273) Stopwatch: simple class to encapsulate
time for statistics gathering
Posted by "Philip Zeyliger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Philip Zeyliger updated AVRO-273:
---------------------------------
Status: Patch Available (was: Open)
> Stopwatch: simple class to encapsulate time for statistics gathering
> --------------------------------------------------------------------
>
> Key: AVRO-273
> URL: https://issues.apache.org/jira/browse/AVRO-273
> Project: Avro
> Issue Type: New Feature
> Components: java
> Reporter: Philip Zeyliger
> Assignee: Philip Zeyliger
> Priority: Minor
> Attachments: AVRO-273.patch.txt, AVRO-273.patch.txt, AVRO-273.patch.txt
>
>
> To measure the duration of an RPC call, I need something that encapsulates the start and stop time. This is something simple that fits the bill.
> The main thing I needed was the ability to swap out tick timers: otherwise things get unwieldy for testing.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.