You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2021/01/11 02:00:48 UTC
[GitHub] [incubator-pinot] fx19880617 opened a new pull request #6430: Adding pinot minion component into helm
fx19880617 opened a new pull request #6430:
URL: https://github.com/apache/incubator-pinot/pull/6430
## Description
Adding Minion component into helm deployment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #6430: Adding pinot minion component into helm
Posted by GitBox <gi...@apache.org>.
fx19880617 commented on a change in pull request #6430:
URL: https://github.com/apache/incubator-pinot/pull/6430#discussion_r557715311
##########
File path: kubernetes/helm/pinot/templates/minion/statefulset.yml
##########
@@ -0,0 +1,108 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+apiVersion: apps/v1
+kind: StatefulSet
+metadata:
+ name: {{ include "pinot.minion.fullname" . }}
+ labels:
+ app: {{ include "pinot.name" . }}
+ chart: {{ include "pinot.chart" . }}
+ component: {{ .Values.minion.name }}
+ release: {{ .Release.Name }}
+ heritage: {{ .Release.Service }}
+spec:
+ selector:
+ matchLabels:
+ app: {{ include "pinot.name" . }}
+ release: {{ .Release.Name }}
+ component: {{ .Values.minion.name }}
+ serviceName: {{ template "pinot.minion.headless" . }}
+ replicas: {{ .Values.minion.replicaCount }}
+ updateStrategy:
+ type: {{ .Values.minion.updateStrategy.type }}
+ podManagementPolicy: Parallel
+ template:
+ metadata:
+ labels:
+ app: {{ include "pinot.name" . }}
+ release: {{ .Release.Name }}
+ component: {{ .Values.minion.name }}
+ annotations:
+{{ toYaml .Values.minion.podAnnotations | indent 8 }}
+ spec:
+ nodeSelector:
+{{ toYaml .Values.minion.nodeSelector | indent 8 }}
+ affinity:
+{{ toYaml .Values.minion.affinity | indent 8 }}
+ tolerations:
+{{ toYaml .Values.minion.tolerations | indent 8 }}
+ containers:
+ - name: minion
+ image: "{{ .Values.image.repository }}:{{ .Values.image.tag }}"
+ imagePullPolicy: {{ .Values.image.pullPolicy }}
+ args: [
+ "StartMinion",
+ "-clusterName", "{{ .Values.cluster.name }}",
+ "-zkAddress", {{ include "zookeeper.url" . | quote }},
+ "-configFileName", "/var/pinot/minion/config/pinot-minion.conf"
+ ]
+ env:
+ - name: JAVA_OPTS
+ value: "{{ .Values.minion.jvmOpts }} -Dlog4j2.configurationFile={{ .Values.minion.log4j2ConfFile }} -Dplugins.dir={{ .Values.minion.pluginsDir }}"
+ ports:
+ - containerPort: {{ .Values.minion.port }}
+ protocol: TCP
+ volumeMounts:
+ - name: config
+ mountPath: /var/pinot/minion/config
+ {{- if .Values.minion.persistence.enabled }}
+ - name: data
+ mountPath: "{{ .Values.minion.persistence.mountPath }}"
+ {{- end }}
+ resources:
+{{ toYaml .Values.minion.resources | indent 12 }}
+ restartPolicy: Always
+ volumes:
+ - name: config
+ configMap:
+ name: {{ include "pinot.minion.config" . }}
+ {{- if not .Values.minion.persistence.enabled }}
+ - name: data
+ emptyDir: {}
+ {{- end }}
+
+ {{- if .Values.minion.persistence.enabled }}
+ volumeClaimTemplates:
+ - metadata:
+ name: data
+ spec:
+ accessModes:
+ - {{ .Values.minion.persistence.accessMode | quote }}
+ {{- if .Values.minion.persistence.storageClass }}
+ {{- if (eq "-" .Values.minion.persistence.storageClass) }}
+ storageClassName: ""
Review comment:
Got it, then we should update this for all the components requires pvcs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] daniellavoie commented on a change in pull request #6430: Adding pinot minion component into helm
Posted by GitBox <gi...@apache.org>.
daniellavoie commented on a change in pull request #6430:
URL: https://github.com/apache/incubator-pinot/pull/6430#discussion_r557396398
##########
File path: kubernetes/helm/pinot/templates/minion/statefulset.yml
##########
@@ -0,0 +1,108 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+apiVersion: apps/v1
+kind: StatefulSet
+metadata:
+ name: {{ include "pinot.minion.fullname" . }}
+ labels:
+ app: {{ include "pinot.name" . }}
+ chart: {{ include "pinot.chart" . }}
+ component: {{ .Values.minion.name }}
+ release: {{ .Release.Name }}
+ heritage: {{ .Release.Service }}
+spec:
+ selector:
+ matchLabels:
+ app: {{ include "pinot.name" . }}
+ release: {{ .Release.Name }}
+ component: {{ .Values.minion.name }}
+ serviceName: {{ template "pinot.minion.headless" . }}
+ replicas: {{ .Values.minion.replicaCount }}
+ updateStrategy:
+ type: {{ .Values.minion.updateStrategy.type }}
+ podManagementPolicy: Parallel
+ template:
+ metadata:
+ labels:
+ app: {{ include "pinot.name" . }}
+ release: {{ .Release.Name }}
+ component: {{ .Values.minion.name }}
+ annotations:
+{{ toYaml .Values.minion.podAnnotations | indent 8 }}
+ spec:
+ nodeSelector:
+{{ toYaml .Values.minion.nodeSelector | indent 8 }}
+ affinity:
+{{ toYaml .Values.minion.affinity | indent 8 }}
+ tolerations:
+{{ toYaml .Values.minion.tolerations | indent 8 }}
+ containers:
+ - name: minion
+ image: "{{ .Values.image.repository }}:{{ .Values.image.tag }}"
+ imagePullPolicy: {{ .Values.image.pullPolicy }}
+ args: [
+ "StartMinion",
+ "-clusterName", "{{ .Values.cluster.name }}",
+ "-zkAddress", {{ include "zookeeper.url" . | quote }},
+ "-configFileName", "/var/pinot/minion/config/pinot-minion.conf"
+ ]
+ env:
+ - name: JAVA_OPTS
+ value: "{{ .Values.minion.jvmOpts }} -Dlog4j2.configurationFile={{ .Values.minion.log4j2ConfFile }} -Dplugins.dir={{ .Values.minion.pluginsDir }}"
+ ports:
+ - containerPort: {{ .Values.minion.port }}
+ protocol: TCP
+ volumeMounts:
+ - name: config
+ mountPath: /var/pinot/minion/config
+ {{- if .Values.minion.persistence.enabled }}
+ - name: data
+ mountPath: "{{ .Values.minion.persistence.mountPath }}"
+ {{- end }}
+ resources:
+{{ toYaml .Values.minion.resources | indent 12 }}
+ restartPolicy: Always
+ volumes:
+ - name: config
+ configMap:
+ name: {{ include "pinot.minion.config" . }}
+ {{- if not .Values.minion.persistence.enabled }}
+ - name: data
+ emptyDir: {}
+ {{- end }}
+
+ {{- if .Values.minion.persistence.enabled }}
+ volumeClaimTemplates:
+ - metadata:
+ name: data
+ spec:
+ accessModes:
+ - {{ .Values.minion.persistence.accessMode | quote }}
+ {{- if .Values.minion.persistence.storageClass }}
+ {{- if (eq "-" .Values.minion.persistence.storageClass) }}
+ storageClassName: ""
Review comment:
Some cloud providers will not support a blank storageClassName.
Something like this would be preferable:
```
{{- if and .Values.server.persistence.storageClass ( not ( empty .Values.server.persistence.storageClass) ) }}
storageClassName: {{ .Values.server.persistence.storageClass }}
{{- end }}
```
This also means that the default blank value from`values.yaml` should be removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] codecov-io edited a comment on pull request #6430: Adding pinot minion component into helm
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #6430:
URL: https://github.com/apache/incubator-pinot/pull/6430#issuecomment-757634200
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6430?src=pr&el=h1) Report
> Merging [#6430](https://codecov.io/gh/apache/incubator-pinot/pull/6430?src=pr&el=desc) (bc87ff6) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/1beaab59b73f26c4e35f3b9bc856b03806cddf5a?el=desc) (1beaab5) will **decrease** coverage by `1.36%`.
> The diff coverage is `56.80%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/6430?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6430 +/- ##
==========================================
- Coverage 66.44% 65.07% -1.37%
==========================================
Files 1075 1320 +245
Lines 54773 64454 +9681
Branches 8168 9398 +1230
==========================================
+ Hits 36396 41946 +5550
- Misses 15700 19515 +3815
- Partials 2677 2993 +316
```
| Flag | Coverage Δ | |
|---|---|---|
| unittests | `65.07% <56.80%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/6430?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...e/pinot/broker/api/resources/PinotBrokerDebug.java](https://codecov.io/gh/apache/incubator-pinot/pull/6430/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYXBpL3Jlc291cmNlcy9QaW5vdEJyb2tlckRlYnVnLmphdmE=) | `0.00% <0.00%> (-79.32%)` | :arrow_down: |
| [...ot/broker/broker/AllowAllAccessControlFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/6430/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYnJva2VyL0FsbG93QWxsQWNjZXNzQ29udHJvbEZhY3RvcnkuamF2YQ==) | `71.42% <ø> (-28.58%)` | :arrow_down: |
| [.../helix/BrokerUserDefinedMessageHandlerFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/6430/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYnJva2VyL2hlbGl4L0Jyb2tlclVzZXJEZWZpbmVkTWVzc2FnZUhhbmRsZXJGYWN0b3J5LmphdmE=) | `33.96% <0.00%> (-32.71%)` | :arrow_down: |
| [...ker/routing/instanceselector/InstanceSelector.java](https://codecov.io/gh/apache/incubator-pinot/pull/6430/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcm91dGluZy9pbnN0YW5jZXNlbGVjdG9yL0luc3RhbmNlU2VsZWN0b3IuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...ava/org/apache/pinot/client/AbstractResultSet.java](https://codecov.io/gh/apache/incubator-pinot/pull/6430/diff?src=pr&el=tree#diff-cGlub3QtY2xpZW50cy9waW5vdC1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY2xpZW50L0Fic3RyYWN0UmVzdWx0U2V0LmphdmE=) | `66.66% <0.00%> (+9.52%)` | :arrow_up: |
| [.../main/java/org/apache/pinot/client/Connection.java](https://codecov.io/gh/apache/incubator-pinot/pull/6430/diff?src=pr&el=tree#diff-cGlub3QtY2xpZW50cy9waW5vdC1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY2xpZW50L0Nvbm5lY3Rpb24uamF2YQ==) | `35.55% <0.00%> (-13.29%)` | :arrow_down: |
| [...inot/client/JsonAsyncHttpPinotClientTransport.java](https://codecov.io/gh/apache/incubator-pinot/pull/6430/diff?src=pr&el=tree#diff-cGlub3QtY2xpZW50cy9waW5vdC1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY2xpZW50L0pzb25Bc3luY0h0dHBQaW5vdENsaWVudFRyYW5zcG9ydC5qYXZh) | `10.90% <0.00%> (-51.10%)` | :arrow_down: |
| [...not/common/assignment/InstancePartitionsUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/6430/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vYXNzaWdubWVudC9JbnN0YW5jZVBhcnRpdGlvbnNVdGlscy5qYXZh) | `73.80% <ø> (+0.63%)` | :arrow_up: |
| [...common/config/tuner/NoOpTableTableConfigTuner.java](https://codecov.io/gh/apache/incubator-pinot/pull/6430/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vY29uZmlnL3R1bmVyL05vT3BUYWJsZVRhYmxlQ29uZmlnVHVuZXIuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...ot/common/config/tuner/RealTimeAutoIndexTuner.java](https://codecov.io/gh/apache/incubator-pinot/pull/6430/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vY29uZmlnL3R1bmVyL1JlYWxUaW1lQXV0b0luZGV4VHVuZXIuamF2YQ==) | `100.00% <ø> (ø)` | |
| ... and [1159 more](https://codecov.io/gh/apache/incubator-pinot/pull/6430/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6430?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6430?src=pr&el=footer). Last update [a5c4ed2...bc87ff6](https://codecov.io/gh/apache/incubator-pinot/pull/6430?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] codecov-io commented on pull request #6430: Adding pinot minion component into helm
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #6430:
URL: https://github.com/apache/incubator-pinot/pull/6430#issuecomment-757634200
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6430?src=pr&el=h1) Report
> Merging [#6430](https://codecov.io/gh/apache/incubator-pinot/pull/6430?src=pr&el=desc) (731f597) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/1beaab59b73f26c4e35f3b9bc856b03806cddf5a?el=desc) (1beaab5) will **decrease** coverage by `22.41%`.
> The diff coverage is `38.51%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/6430?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6430 +/- ##
===========================================
- Coverage 66.44% 44.03% -22.42%
===========================================
Files 1075 1320 +245
Lines 54773 64454 +9681
Branches 8168 9398 +1230
===========================================
- Hits 36396 28381 -8015
- Misses 15700 33712 +18012
+ Partials 2677 2361 -316
```
| Flag | Coverage Δ | |
|---|---|---|
| integration | `44.03% <38.51%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/6430?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ot/broker/broker/AllowAllAccessControlFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/6430/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYnJva2VyL0FsbG93QWxsQWNjZXNzQ29udHJvbEZhY3RvcnkuamF2YQ==) | `100.00% <ø> (ø)` | |
| [.../helix/BrokerUserDefinedMessageHandlerFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/6430/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYnJva2VyL2hlbGl4L0Jyb2tlclVzZXJEZWZpbmVkTWVzc2FnZUhhbmRsZXJGYWN0b3J5LmphdmE=) | `52.83% <0.00%> (-13.84%)` | :arrow_down: |
| [...org/apache/pinot/broker/queryquota/HitCounter.java](https://codecov.io/gh/apache/incubator-pinot/pull/6430/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcXVlcnlxdW90YS9IaXRDb3VudGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...che/pinot/broker/queryquota/MaxHitRateTracker.java](https://codecov.io/gh/apache/incubator-pinot/pull/6430/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcXVlcnlxdW90YS9NYXhIaXRSYXRlVHJhY2tlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...ache/pinot/broker/queryquota/QueryQuotaEntity.java](https://codecov.io/gh/apache/incubator-pinot/pull/6430/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcXVlcnlxdW90YS9RdWVyeVF1b3RhRW50aXR5LmphdmE=) | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
| [...ker/routing/instanceselector/InstanceSelector.java](https://codecov.io/gh/apache/incubator-pinot/pull/6430/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcm91dGluZy9pbnN0YW5jZXNlbGVjdG9yL0luc3RhbmNlU2VsZWN0b3IuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...ceselector/StrictReplicaGroupInstanceSelector.java](https://codecov.io/gh/apache/incubator-pinot/pull/6430/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcm91dGluZy9pbnN0YW5jZXNlbGVjdG9yL1N0cmljdFJlcGxpY2FHcm91cEluc3RhbmNlU2VsZWN0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...roker/routing/segmentpruner/TimeSegmentPruner.java](https://codecov.io/gh/apache/incubator-pinot/pull/6430/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcm91dGluZy9zZWdtZW50cHJ1bmVyL1RpbWVTZWdtZW50UHJ1bmVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...roker/routing/segmentpruner/interval/Interval.java](https://codecov.io/gh/apache/incubator-pinot/pull/6430/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcm91dGluZy9zZWdtZW50cHJ1bmVyL2ludGVydmFsL0ludGVydmFsLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...r/routing/segmentpruner/interval/IntervalTree.java](https://codecov.io/gh/apache/incubator-pinot/pull/6430/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcm91dGluZy9zZWdtZW50cHJ1bmVyL2ludGVydmFsL0ludGVydmFsVHJlZS5qYXZh) | `0.00% <0.00%> (ø)` | |
| ... and [1309 more](https://codecov.io/gh/apache/incubator-pinot/pull/6430/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6430?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6430?src=pr&el=footer). Last update [a5c4ed2...731f597](https://codecov.io/gh/apache/incubator-pinot/pull/6430?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #6430: Adding pinot minion component into helm
Posted by GitBox <gi...@apache.org>.
fx19880617 commented on a change in pull request #6430:
URL: https://github.com/apache/incubator-pinot/pull/6430#discussion_r557728455
##########
File path: kubernetes/helm/pinot/templates/minion/statefulset.yml
##########
@@ -0,0 +1,108 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+apiVersion: apps/v1
+kind: StatefulSet
+metadata:
+ name: {{ include "pinot.minion.fullname" . }}
+ labels:
+ app: {{ include "pinot.name" . }}
+ chart: {{ include "pinot.chart" . }}
+ component: {{ .Values.minion.name }}
+ release: {{ .Release.Name }}
+ heritage: {{ .Release.Service }}
+spec:
+ selector:
+ matchLabels:
+ app: {{ include "pinot.name" . }}
+ release: {{ .Release.Name }}
+ component: {{ .Values.minion.name }}
+ serviceName: {{ template "pinot.minion.headless" . }}
+ replicas: {{ .Values.minion.replicaCount }}
+ updateStrategy:
+ type: {{ .Values.minion.updateStrategy.type }}
+ podManagementPolicy: Parallel
+ template:
+ metadata:
+ labels:
+ app: {{ include "pinot.name" . }}
+ release: {{ .Release.Name }}
+ component: {{ .Values.minion.name }}
+ annotations:
+{{ toYaml .Values.minion.podAnnotations | indent 8 }}
+ spec:
+ nodeSelector:
+{{ toYaml .Values.minion.nodeSelector | indent 8 }}
+ affinity:
+{{ toYaml .Values.minion.affinity | indent 8 }}
+ tolerations:
+{{ toYaml .Values.minion.tolerations | indent 8 }}
+ containers:
+ - name: minion
+ image: "{{ .Values.image.repository }}:{{ .Values.image.tag }}"
+ imagePullPolicy: {{ .Values.image.pullPolicy }}
+ args: [
+ "StartMinion",
+ "-clusterName", "{{ .Values.cluster.name }}",
+ "-zkAddress", {{ include "zookeeper.url" . | quote }},
+ "-configFileName", "/var/pinot/minion/config/pinot-minion.conf"
+ ]
+ env:
+ - name: JAVA_OPTS
+ value: "{{ .Values.minion.jvmOpts }} -Dlog4j2.configurationFile={{ .Values.minion.log4j2ConfFile }} -Dplugins.dir={{ .Values.minion.pluginsDir }}"
+ ports:
+ - containerPort: {{ .Values.minion.port }}
+ protocol: TCP
+ volumeMounts:
+ - name: config
+ mountPath: /var/pinot/minion/config
+ {{- if .Values.minion.persistence.enabled }}
+ - name: data
+ mountPath: "{{ .Values.minion.persistence.mountPath }}"
+ {{- end }}
+ resources:
+{{ toYaml .Values.minion.resources | indent 12 }}
+ restartPolicy: Always
+ volumes:
+ - name: config
+ configMap:
+ name: {{ include "pinot.minion.config" . }}
+ {{- if not .Values.minion.persistence.enabled }}
+ - name: data
+ emptyDir: {}
+ {{- end }}
+
+ {{- if .Values.minion.persistence.enabled }}
+ volumeClaimTemplates:
+ - metadata:
+ name: data
+ spec:
+ accessModes:
+ - {{ .Values.minion.persistence.accessMode | quote }}
+ {{- if .Values.minion.persistence.storageClass }}
+ {{- if (eq "-" .Values.minion.persistence.storageClass) }}
+ storageClassName: ""
Review comment:
I will update this in a different PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] codecov-io edited a comment on pull request #6430: Adding pinot minion component into helm
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #6430:
URL: https://github.com/apache/incubator-pinot/pull/6430#issuecomment-757634200
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6430?src=pr&el=h1) Report
> Merging [#6430](https://codecov.io/gh/apache/incubator-pinot/pull/6430?src=pr&el=desc) (9d38ed4) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/1beaab59b73f26c4e35f3b9bc856b03806cddf5a?el=desc) (1beaab5) will **decrease** coverage by `22.37%`.
> The diff coverage is `38.41%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/6430?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6430 +/- ##
===========================================
- Coverage 66.44% 44.07% -22.38%
===========================================
Files 1075 1320 +245
Lines 54773 64454 +9681
Branches 8168 9398 +1230
===========================================
- Hits 36396 28407 -7989
- Misses 15700 33686 +17986
+ Partials 2677 2361 -316
```
| Flag | Coverage Δ | |
|---|---|---|
| integration | `44.07% <38.41%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/6430?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ot/broker/broker/AllowAllAccessControlFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/6430/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYnJva2VyL0FsbG93QWxsQWNjZXNzQ29udHJvbEZhY3RvcnkuamF2YQ==) | `100.00% <ø> (ø)` | |
| [.../helix/BrokerUserDefinedMessageHandlerFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/6430/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYnJva2VyL2hlbGl4L0Jyb2tlclVzZXJEZWZpbmVkTWVzc2FnZUhhbmRsZXJGYWN0b3J5LmphdmE=) | `52.83% <0.00%> (-13.84%)` | :arrow_down: |
| [...org/apache/pinot/broker/queryquota/HitCounter.java](https://codecov.io/gh/apache/incubator-pinot/pull/6430/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcXVlcnlxdW90YS9IaXRDb3VudGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...che/pinot/broker/queryquota/MaxHitRateTracker.java](https://codecov.io/gh/apache/incubator-pinot/pull/6430/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcXVlcnlxdW90YS9NYXhIaXRSYXRlVHJhY2tlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...ache/pinot/broker/queryquota/QueryQuotaEntity.java](https://codecov.io/gh/apache/incubator-pinot/pull/6430/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcXVlcnlxdW90YS9RdWVyeVF1b3RhRW50aXR5LmphdmE=) | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
| [...ker/routing/instanceselector/InstanceSelector.java](https://codecov.io/gh/apache/incubator-pinot/pull/6430/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcm91dGluZy9pbnN0YW5jZXNlbGVjdG9yL0luc3RhbmNlU2VsZWN0b3IuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...ceselector/StrictReplicaGroupInstanceSelector.java](https://codecov.io/gh/apache/incubator-pinot/pull/6430/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcm91dGluZy9pbnN0YW5jZXNlbGVjdG9yL1N0cmljdFJlcGxpY2FHcm91cEluc3RhbmNlU2VsZWN0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...roker/routing/segmentpruner/TimeSegmentPruner.java](https://codecov.io/gh/apache/incubator-pinot/pull/6430/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcm91dGluZy9zZWdtZW50cHJ1bmVyL1RpbWVTZWdtZW50UHJ1bmVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...roker/routing/segmentpruner/interval/Interval.java](https://codecov.io/gh/apache/incubator-pinot/pull/6430/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcm91dGluZy9zZWdtZW50cHJ1bmVyL2ludGVydmFsL0ludGVydmFsLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...r/routing/segmentpruner/interval/IntervalTree.java](https://codecov.io/gh/apache/incubator-pinot/pull/6430/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcm91dGluZy9zZWdtZW50cHJ1bmVyL2ludGVydmFsL0ludGVydmFsVHJlZS5qYXZh) | `0.00% <0.00%> (ø)` | |
| ... and [1309 more](https://codecov.io/gh/apache/incubator-pinot/pull/6430/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6430?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6430?src=pr&el=footer). Last update [a5c4ed2...9d38ed4](https://codecov.io/gh/apache/incubator-pinot/pull/6430?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] fx19880617 merged pull request #6430: Adding pinot minion component into helm
Posted by GitBox <gi...@apache.org>.
fx19880617 merged pull request #6430:
URL: https://github.com/apache/incubator-pinot/pull/6430
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org