You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/05/11 10:15:04 UTC

[jira] [Commented] (GEODE-265) Remove deprecated methods on Execution interface

    [ https://issues.apache.org/jira/browse/GEODE-265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16006192#comment-16006192 ] 

ASF GitHub Bot commented on GEODE-265:
--------------------------------------

GitHub user deepakddixit opened a pull request:

    https://github.com/apache/geode/pull/509

    GEODE-265: Removing deprecated API from Execution interface.

    - Removed following deprecated API from Execution interface
    
    1. public Execution<IN, OUT, AGG> withArgs(IN args)
    2. public ResultCollector<?, ?> execute(String functionId, boolean hasResult)
          throws FunctionException
    3. public ResultCollector<?, ?> execute(String functionId, boolean hasResult, boolean isHA)
          throws FunctionException;
    4. public ResultCollector<?, ?> execute(String functionId, boolean hasResult, boolean isHA,
          boolean optimizeForWrite) throws FunctionException
    
    - Removed implementation of these deprecated API's
    
    - Fixed RollingUpgrade2DUnitTest.
     

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/deepakddixit/incubator-geode feature/GEODE-265

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode/pull/509.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #509
    
----
commit e0493d67567abc9fcd8071f91031e3834d788884
Author: Deepak Dixit <de...@gmail.com>
Date:   2017-05-08T11:04:59Z

    GEODE-265 : Removing deprecated API's from Execution interface.
    In addition to execute method variants removed withArgs method which is deprecated as well.

commit 426d74a536f4ef4fc6c336c020f1de269bd7fe66
Author: Deepak Dixit <de...@gmail.com>
Date:   2017-05-10T12:44:24Z

    GEODE-265 : Removing implementation of methods which are deprecated and are removed from Execution interface.

commit 834ef9e7160755fd7f95d58393f1d63f41cb8332
Author: Deepak Dixit <de...@gmail.com>
Date:   2017-05-11T09:44:58Z

    GEODE-269 : Fixing RollingUpgrade2DUnitTest. After removing deprecated API withArgs, setArgument alternative API is not available in older version of server causing NoSuchMethodFound exception. The role of setArgument with function is passing class name to load inside the function. As the relevant function is used on in the context of this test, instead of using setArgument method made class name as a field in GetDataSerializableFunction.

commit c628e701ae35fc6c298c0d3893bdbf14c4a32df8
Author: Deepak Dixit <de...@gmail.com>
Date:   2017-05-11T10:09:46Z

    GEODE-269 : SpotlessApply changes.

----


> Remove deprecated methods on Execution interface
> ------------------------------------------------
>
>                 Key: GEODE-265
>                 URL: https://issues.apache.org/jira/browse/GEODE-265
>             Project: Geode
>          Issue Type: Sub-task
>            Reporter: Darrel Schneider
>            Assignee: Deepak Dixit
>   Original Estimate: 5h
>  Remaining Estimate: 5h
>
> The Execution interface has a number of execute methods that have been deprecated. It looks like these could be easily removed.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)