[GitHub] adityaxavier commented on issue #200: Modified iBeacon and Eddystone

[GitBox <gi...@apache.org>]

adityaxavier commented on issue #200: Modified iBeacon and Eddystone
URL: https://github.com/apache/mynewt-nimble/pull/200#issuecomment-425695168
 
 
   > iBeacon uses 30 (out of 31) bytes of advertising data so not sure how would you like to fit more data there?
   
   Am sorry I don't understand what you are saying. Previously, tx_pwr (intt8_t) was being appended in the buf for both iBeacon and Eddystone. This was as protocol (byte 25-26) were meant for Measured Power. However the problem was it was being generated automatically instead of taking as an argument from the User. This should have been a user defined parameter as this value depends on HW , antenna design, Casing etc. This change is done on both iBeacon and Eddystone.
   Apart from that commit, I have reused the ble_hs_adv_fields in iBeacon similar to what was done in Eddystone. This allows us to pass along ble_hs_adv_fields parameters instead of overwriting them, for e.g in my use case I wanted BLE to have a name.
   
   I hope this clears this up.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services